Changeset 5987 for trunk/bp-core/bp-core-template.php

Timestamp:

04/13/2012 04:31:51 PM (14 years ago)

Author:

boonebgorges

Message:

'Total member count' cleanup:

• Introduces bp_core_get_active_member_count() to get an accurate count of members with recorded last_activity
• Points bp_get_total_member_count() to bp_core_get_active_member_count(), so that 'All Members' tab count on member directories matches the total count prepared by BP_Core_User::get_users(). Fixes #4061
• Changes 'All Members' count in activity/index.php to use bp_get_total_member_count(), for greater accuracy and consistency between activity and members components
• Introduces a cache-busting function to be fired when member counts change (new members, spam status changed, member deleted)

File:

• trunk/bp-core/bp-core-template.php (modified) (1 diff)

trunk/bp-core/bp-core-template.php

@@ -503 +503 @@
 add_filter( 'bp_create_excerpt', 'force_balance_tags' );
 
+/**
+ * Echoes the output of bp_get_total_member_count()
+ */
 function bp_total_member_count() {
         echo bp_get_total_member_count();
 }
+        /**
+         * Returns the total member count in your BP instance
+         *
+         * Since BuddyPress 1.6, this function has used bp_core_get_active_member_count(), which
+         * counts non-spam, non-deleted users who have last_activity. This value will correctly
+         * match the total member count number used for pagination on member directories.
+         *
+         * Before BuddyPress 1.6, this function used bp_core_get_total_member_count(), which did
+         * not take into account last_activity, and thus often resulted in higher counts than
+         * shown by member directory pagination.
+         */
         function bp_get_total_member_count() {
-                return apply_filters( 'bp_get_total_member_count', bp_core_get_total_member_count() );
+                return apply_filters( 'bp_get_total_member_count', bp_core_get_active_member_count() );
         }
         add_filter( 'bp_get_total_member_count', 'bp_core_number_format' );