Changeset 5808

Timestamp:

02/19/2012 02:22:00 PM (13 years ago)

Author:

boonebgorges

Message:

Deprecates groups_check_group_exists() in favor of more aptly named groups_get_id(). Fixes #4023

Location:

trunk

Files:

• bp-core/deprecated/1.6.php (modified) (1 diff)
• bp-groups/bp-groups-functions.php (modified) (2 diffs)

trunk/bp-core/deprecated/1.6.php

@@ -88 +88 @@
 
 /**
+ * Groups functions
+ */
+
+/**
+ * @deprecated 1.6
+ * @deprecated Renamed to groups_get_id() for greater consistency
+ */
+function groups_check_group_exists( $group_slug ) {
+    _deprecated_function( __FUNCTION__, '1.6', 'groups_get_id()' );
+    return groups_get_id( $group_slug );
+}
+
+/**
  * Activity functions
  */

trunk/bp-groups/bp-groups-functions.php

@@ -258 +258 @@
 }
 
+/**
+ * Get a group slug by its ID
+ *
+ * @param int $group_id The numeric ID of the group
+ * @return string The group's slug
+ */
 function groups_get_slug( $group_id ) {
     $group = groups_get_group( array( 'group_id' => $group_id ) );
-    return $group->slug;
+    return !empty( $group->slug ) ? $group->slug : '';
+}
+
+/**
+ * Get a group ID by its slug
+ *
+ * @since 1.6
+ *
+ * @param string $group_slug The group's slug
+ * @return int The ID
+ */
+function groups_get_id( $group_slug ) {
+    return (int)BP_Groups_Group::group_exists( $group_slug );
 }
 
@@ -359 +377 @@
 
 /*** General Group Functions ****************************************************/
-
-function groups_check_group_exists( $group_id ) {
-    return BP_Groups_Group::group_exists( $group_id );
-}
 
 function groups_get_group_admins( $group_id ) {