Changeset 5699 for trunk/bp-xprofile/bp-xprofile-screens.php

Timestamp:

02/11/2012 02:14:07 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Remove unneeded globals and clean up some code in XProfile component. See #3989.

File:

• trunk/bp-xprofile/bp-xprofile-screens.php (modified) (5 diffs)

trunk/bp-xprofile/bp-xprofile-screens.php

@@ -1 +1 @@
 <?php
-/*******************************************************************************
+
+/**
+ * BuddyPress XProfile Screens
+ *
  * Screen functions are the controllers of BuddyPress. They will execute when
  * their specific URL is caught. They will first save or manipulate data using
  * business functions, then pass on the user to a template file.
+ *
+ * @package BuddyPress
+ * @subpackage XProfileScreens
  */
 
@@ -46 +52 @@
     }
 
+    // No errors
+    $errors = false;
+
     // Check to see if any new information has been submitted
     if ( isset( $_POST['field_ids'] ) ) {
@@ -77 +86 @@
 
             $is_required[$field_id] = xprofile_check_is_required_field( $field_id );
-            if ( $is_required[$field_id] && empty( $_POST['field_' . $field_id] ) )
+            if ( $is_required[$field_id] && empty( $_POST['field_' . $field_id] ) ) {
                 $errors = true;
+            }
         }
 
@@ -87 +97 @@
         // No errors
         } else {
+
             // Reset the errors var
             $errors = false;
@@ -108 +119 @@
 
             // Set the feedback messages
-            if ( $errors )
+            if ( !empty( $errors ) )
                 bp_core_add_message( __( 'There was a problem updating some of your profile information, please try again.', 'buddypress' ), 'error' );
             else