Changeset 5689 for trunk/bp-groups/bp-groups-activity.php

Timestamp:

02/10/2012 01:17:51 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Remove unneeded globals and clean up some code in Groups component. See #3989.

File:

• trunk/bp-groups/bp-groups-activity.php (modified) (3 diffs)

trunk/bp-groups/bp-groups-activity.php

@@ -1 +1 @@
 <?php
+
 /**
  * BuddyPress Groups Activity & Notification Functions
@@ -63 +64 @@
     global $bp;
 
-    if ( !$group_id )
+    if ( empty( $group_id ) )
         $group_id = $bp->groups->current_group->id;
 
-    if ( !$group_id )
+    if ( empty( $group_id ) )
         return false;
 
     groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
 }
-add_action( 'groups_leave_group', 'groups_update_last_activity' );
-add_action( 'groups_created_group', 'groups_update_last_activity' );
-add_action( 'groups_new_forum_topic', 'groups_update_last_activity' );
+add_action( 'groups_leave_group',          'groups_update_last_activity' );
+add_action( 'groups_created_group',        'groups_update_last_activity' );
+add_action( 'groups_new_forum_topic',      'groups_update_last_activity' );
 add_action( 'groups_new_forum_topic_post', 'groups_update_last_activity' );
 
 function groups_format_notifications( $action, $item_id, $secondary_item_id, $total_items, $format = 'string' ) {
-    global $bp;
 
     switch ( $action ) {
@@ -305 +305 @@
     return false;
 }
+
 ?>