Changeset 5683 for trunk/bp-core/bp-core-avatars.php

Timestamp:

02/09/2012 09:38:45 PM (13 years ago)

Author:

johnjamesjacoby

Message:

Remove a bunch of unneeded globals and clean up some code in Core component. See #3989.

File:

• trunk/bp-core/bp-core-avatars.php (modified) (3 diffs)

trunk/bp-core/bp-core-avatars.php

@@ -390 +390 @@
     extract( $args, EXTR_SKIP );
 
-    if ( !$item_id ) {
+    if ( empty( $item_id ) ) {
         if ( 'user' == $object )
             $item_id = bp_displayed_user_id();
@@ -403 +403 @@
     }
 
-    if ( !$avatar_dir ) {
+    if ( empty( $avatar_dir ) ) {
         if ( 'user' == $object )
             $avatar_dir = 'avatars';
@@ -548 +548 @@
  *  crop_y - The vertical starting point of the crop
  *
- * @global object $bp BuddyPress global settings
  * @param mixed $args
  * @return bool Success/failure
  */
 function bp_core_avatar_handle_crop( $args = '' ) {
-    global $bp;
 
     $defaults = array(