Skip to:
Content

BuddyPress.org

Changeset 527 for trunk/bp-groups.php


Ignore:
Timestamp:
11/10/2008 11:22:03 AM (17 years ago)
Author:
apeatling
Message:

Added new function "bp_core_redirect()" to perform safe "wp_redirect()" calls. Stops bug with redirection loops and multiple friend confirmations.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-groups.php

    r524 r527  
    288288            bp_core_add_message( __('Group invite could not be accepted', 'buddypress'), 'error' );         
    289289        }
    290         wp_redirect( $_SERVER['HTTP_REFERER'] );
     290        bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    291291       
    292292    } else if ( isset($bp['action_variables']) && in_array( 'reject', $bp['action_variables'] ) && is_numeric($bp['action_variables'][1]) ) {
     
    296296            bp_core_add_message( __('Group invite could not be rejected', 'buddypress'), 'error' );         
    297297        }
    298         wp_redirect( $_SERVER['HTTP_REFERER'] );
     298        bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    299299    }
    300300   
     
    336336            // We're done.
    337337            if ( $create_group_step == 4 )
    338                 wp_redirect( bp_group_permalink( $group_obj, false ) );
     338                bp_core_redirect( bp_group_permalink( $group_obj, false ) );
    339339
    340340            if ( !$group_id = groups_manage_group( $create_group_step, $_SESSION['group_obj_id'] ) ) {
    341341                bp_core_add_message( __('There was an error saving group details. Please try again.', 'buddypress'), 'error' );
    342                 wp_redirect( $bp['loggedin_domain'] . $bp['groups']['slug'] . '/create/step/' . $create_group_step );
     342                bp_core_redirect( $bp['loggedin_domain'] . $bp['groups']['slug'] . '/create/step/' . $create_group_step );
    343343            } else {
    344344                $create_group_step++;
     
    396396           
    397397            if ( !strpos( $_SERVER['HTTP_REFERER'], $bp['wire']['slug'] ) ) {
    398                 wp_redirect( bp_group_permalink( $group_obj, false ) );
     398                bp_core_redirect( bp_group_permalink( $group_obj, false ) );
    399399            } else {
    400                 wp_redirect( bp_group_permalink( $group_obj, false ) . '/' . $bp['wire']['slug'] );
     400                bp_core_redirect( bp_group_permalink( $group_obj, false ) . '/' . $bp['wire']['slug'] );
    401401            }
    402402   
     
    411411           
    412412            if ( !strpos( $_SERVER['HTTP_REFERER'], $bp['wire']['slug'] ) ) {
    413                 wp_redirect( bp_group_permalink( $group_obj, false ) );
     413                bp_core_redirect( bp_group_permalink( $group_obj, false ) );
    414414            } else {
    415                 wp_redirect( bp_group_permalink( $group_obj, false ) . '/' . $bp['wire']['slug'] );
     415                bp_core_redirect( bp_group_permalink( $group_obj, false ) . '/' . $bp['wire']['slug'] );
    416416            }
    417417       
     
    453453           
    454454            bp_core_add_message( __('Group invites sent.', 'buddypress') );
    455             wp_redirect( bp_group_permalink( $group_obj, false ) );
     455            bp_core_redirect( bp_group_permalink( $group_obj, false ) );
    456456        } else {
    457457            // Show send invite page
     
    470470            if ( !groups_leave_group( $group_obj->id ) ) {
    471471                bp_core_add_message(  __('There was an error leaving the group. Please try again.', 'buddypress'), 'error' );
    472                 wp_redirect( bp_group_permalink( $group_obj, false) );
     472                bp_core_redirect( bp_group_permalink( $group_obj, false) );
    473473            } else {
    474474                bp_core_add_message( __('You left the group successfully.', 'buddypress') );
    475                 wp_redirect( $bp['loggedin_domain'] . $bp['groups']['slug'] );
     475                bp_core_redirect( $bp['loggedin_domain'] . $bp['groups']['slug'] );
    476476            }
    477477        } else if ( isset($bp['action_variables']) && $bp['action_variables'][0] == 'no' ) {
    478             wp_redirect( bp_group_permalink( $group_obj, false) );
     478            bp_core_redirect( bp_group_permalink( $group_obj, false) );
    479479        } else {
    480480            // Show leave group page
     
    498498                bp_core_add_message( __( 'Your membership request was sent to the group administrator successfully. You will be notified when the group administrator responds to your request.', 'buddypress' ) );
    499499            }
    500             wp_redirect( bp_group_permalink( $group_obj, false ) );
     500            bp_core_redirect( bp_group_permalink( $group_obj, false ) );
    501501        }
    502502        bp_catch_uri( 'groups/request-membership' );
     
    526526                bp_core_add_message( __( 'Group details were successfully updated.', 'buddypress' ) );
    527527            }
    528             wp_redirect( $_SERVER['HTTP_REFERER'] );
     528            bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    529529        }
    530530
     
    557557            }
    558558           
    559             wp_redirect( $_SERVER['HTTP_REFERER'] );
     559            bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    560560        }
    561561       
     
    596596                }   
    597597            }
    598             wp_redirect( $_SERVER['HTTP_REFERER'] );
     598            bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    599599        }
    600600       
     
    618618            } else {
    619619                bp_core_add_message( __( 'The group was deleted successfully', 'buddypress' ) );
    620                 wp_redirect( site_url() . '/' . $bp['groups']['slug'] . '/' );
     620                bp_core_redirect( site_url() . '/' . $bp['groups']['slug'] . '/' );
    621621            }
    622             wp_redirect( $_SERVER['HTTP_REFERER'] );
     622            bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    623623        } else {
    624624            bp_catch_uri( 'groups/admin/delete-group' );
     
    691691            bp_core_add_message( __('You joined the group!', 'buddypress') );
    692692        }
    693         wp_redirect( $_SERVER['HTTP_REFERER'] );
     693        bp_core_redirect( $_SERVER['HTTP_REFERER'] );
    694694    }
    695695
Note: See TracChangeset for help on using the changeset viewer.