Changeset 5203

Timestamp:

09/30/2011 10:38:56 PM (13 years ago)

Author:

djpaul

Message:

Prevent sole admins leaving groups. See #3631

Location:

branches/1.5/bp-groups

Files:

• bp-groups-actions.php (modified) (1 diff)
• bp-groups-screens.php (modified) (1 diff)

branches/1.5/bp-groups/bp-groups-actions.php

@@ -244 +244 @@
     // User wants to leave any group
     if ( groups_is_user_member( $bp->loggedin_user->id, $bp->groups->current_group->id ) ) {
-        if ( !groups_leave_group( $bp->groups->current_group->id ) ) {
+
+        // Stop sole admins from abandoning their group
+        $group_admins = groups_get_group_admins( $bp->groups->current_group->id );
+        if ( 1 == count( $group_admins ) && $group_admins[0]->user_id == $bp->loggedin_user->id )
+            bp_core_add_message( __( 'This group must have at least one admin', 'buddypress' ), 'error' );
+
+        elseif ( !groups_leave_group( $bp->groups->current_group->id ) )
             bp_core_add_message( __( 'There was an error leaving the group.', 'buddypress' ), 'error' );
-        } else {
+        else
             bp_core_add_message( __( 'You successfully left the group.', 'buddypress' ) );
-        }
+
         bp_core_redirect( bp_get_group_permalink( $bp->groups->current_group ) );
     }

branches/1.5/bp-groups/bp-groups-screens.php

@@ -641 +641 @@
                     return false;
 
+                // Stop sole admins from abandoning their group
+                $group_admins = groups_get_group_admins( $bp->groups->current_group->id );
+                if ( 1 == count( $group_admins ) && $group_admins[0]->user_id == $user_id )
+                    bp_core_add_message( __( 'This group must have at least one admin', 'buddypress' ), 'error' );
+
                 // Demote a user.
-                if ( !groups_demote_member( $user_id, $bp->groups->current_group->id ) )
+                elseif ( !groups_demote_member( $user_id, $bp->groups->current_group->id ) )
                     bp_core_add_message( __( 'There was an error when demoting that user, please try again', 'buddypress' ), 'error' );
                 else