Changeset 4902

Timestamp:

07/30/2011 11:25:01 AM (14 years ago)

Author:

boonebgorges

Message:

Removes null recipients from recipient_ids array before attempting to send private message. Fixes #3411

Location:

trunk/bp-messages

Files:

• bp-messages-actions.php (modified) (1 diff)
• bp-messages-functions.php (modified) (3 diffs)

trunk/bp-messages/bp-messages-actions.php

@@ -10 +10 @@
 
 function messages_action_view_message() {
-    global $thread_id;
+    global $thread_id, $bp;
 
     if ( !bp_is_messages_component() || !bp_is_current_action( 'view' ) )

trunk/bp-messages/bp-messages-functions.php

@@ -56 +56 @@
             $message->subject = __( 'No Subject', 'buddypress' );
 
-        $recipient_ids = array();
+        $recipient_ids      = array();
+        
+        // Invalid recipients are added to an array, for future enhancements
+        $invalid_recipients = array();
 
         // Loop the recipients and convert all usernames to user_ids where needed
@@ -66 +69 @@
             if ( is_numeric( $recipient ) ) {
                 if ( bp_core_get_core_userdata( (int) $recipient ) )
-                    $recipient_ids[] = (int) $recipient;
+                    $recipient_id = (int) $recipient;
 
             } else {
@@ -73 +76 @@
                 else
                     $recipient_id = bp_core_get_userid_from_nicename( $recipient );
-
+            }
+            
+            if ( !$recipient_id )
+                $invalid_recipients[] = $recipient;
+            else
                 $recipient_ids[] = (int) $recipient_id;
-            }
         }