Changeset 4840 for trunk/bp-xprofile/bp-xprofile-screens.php

Timestamp:

07/24/2011 10:22:55 PM (15 years ago)

Author:

boonebgorges

Message:

Introduces wrapper functions for retrieving and checking items in bp->action_variables. action_variables audit for xprofile component. See #3325

File:

• trunk/bp-xprofile/bp-xprofile-screens.php (modified) (5 diffs)

trunk/bp-xprofile/bp-xprofile-screens.php

@@ -37 +37 @@
 
     // Make sure a group is set.
-    if ( empty( $bp->action_variables[1] ) )
-        bp_core_redirect( $bp->displayed_user->domain . $bp->profile->slug . '/edit/group/1' );
+    if ( !bp_action_variable( 1 ) )
+        bp_core_redirect( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/1' );
 
     // Check the field group exists
-    if ( ( !empty( $bp->action_variables[0] ) && 'group' != $bp->action_variables[0] ) || !xprofile_get_field_group( $bp->action_variables[1] ) ) {
+    if ( !bp_is_action_variable( 'group' ) || !xprofile_get_field_group( bp_action_variable( 1 ) ) ) {
         bp_do_404();
         return;
@@ -54 +54 @@
         // Check we have field ID's
         if ( empty( $_POST['field_ids'] ) )
-            bp_core_redirect( trailingslashit( $bp->displayed_user->domain . $bp->profile->slug . '/edit/group/' . $bp->action_variables[1] ) );
+            bp_core_redirect( trailingslashit( $bp->displayed_user->domain . $bp->profile->slug . '/edit/group/' . bp_action_variable( 1 ) ) );
 
         // Explode the posted field IDs into an array so we know which
@@ -68 +68 @@
                 if ( !empty( $_POST['field_' . $field_id . '_day'] ) && is_numeric( $_POST['field_' . $field_id . '_day'] ) ) {
                     // Concatenate the values
-                    $date_value =   $_POST['field_' . $field_id . '_day'] . ' ' .
-                                    $_POST['field_' . $field_id . '_month'] . ' ' .
-                                    $_POST['field_' . $field_id . '_year'];
+                    $date_value =   $_POST['field_' . $field_id . '_day'] . ' ' . $_POST['field_' . $field_id . '_month'] . ' ' . $_POST['field_' . $field_id . '_year'];
 
                     // Turn the concatenated value into a timestamp
@@ -116 +114 @@
 
             // Redirect back to the edit screen to display the updates and message
-            bp_core_redirect( trailingslashit( $bp->displayed_user->domain . $bp->profile->slug . '/edit/group/' . $bp->action_variables[1] ) );
+            bp_core_redirect( trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/' . bp_action_variable( 1 ) ) );
         }
     }
@@ -137 +135 @@
         return false;
 
-    if ( !empty( $bp->action_variables ) ) {
+    if ( bp_action_variables() ) {
         bp_do_404();
         return;