Changeset 4770 for trunk/bp-xprofile/bp-xprofile-template.php

Timestamp:

07/21/2011 10:27:09 PM (13 years ago)

Author:

djpaul

Message:

Tune up 'for' loops. Fixes #2985, props cnorris23 and r-a-y

File:

• trunk/bp-xprofile/bp-xprofile-template.php (modified) (4 diffs)

trunk/bp-xprofile/bp-xprofile-template.php

@@ -103 +103 @@
         $has_data = false;
 
-        for ( $i = 0; $i < count( $this->group->fields ); $i++ ) {
+        for ( $i = 0, $count = count( $this->group->fields ); $i < $count; ++$i ) {
             $field = &$this->group->fields[$i];
 
@@ -548 +548 @@
                         $html .= '<option value=""' . selected( $day, '', false ) . '>--</option>';
 
-                        for ( $i = 1; $i < 32; $i++ ) {
+                        for ( $i = 1; $i < 32; ++$i ) {
                             $html .= '<option value="' . $i .'"' . selected( $day, $i, false ) . '>' . $i . '</option>';
                         }
@@ -564 +564 @@
                         $html .= '<option value=""' . selected( $month, '', false ) . '>------</option>';
 
-                        for ( $i = 0; $i < 12; $i++ ) {
+                        for ( $i = 0; $i < 12; ++$i ) {
                             $html .= '<option value="' . $eng_months[$i] . '"' . selected( $month, $eng_months[$i], false ) . '>' . $months[$i] . '</option>';
                         }
@@ -634 +634 @@
 
     $tabs = array();
-    for ( $i = 0, $count = count( $groups ); $i < $count; $i++ ) {
+    for ( $i = 0, $count = count( $groups ); $i < $count; ++$i ) {
         if ( $group_name == $groups[$i]->name )
             $selected = ' class="current"';