Changeset 4770 for trunk/bp-xprofile/bp-xprofile-classes.php

Timestamp:

07/21/2011 10:27:09 PM (13 years ago)

Author:

djpaul

Message:

Tune up 'for' loops. Fixes #2985, props cnorris23 and r-a-y

File:

• trunk/bp-xprofile/bp-xprofile-classes.php (modified) (4 diffs)

trunk/bp-xprofile/bp-xprofile-classes.php

@@ -73 +73 @@
             if ( BP_XProfile_Field::delete_for_group( $this->id ) ) {
                 /* Remove profile data for the groups fields */
-                for ( $i = 0; $i < count( $this->fields ); $i++ ) {
+                for ( $i = 0, $count = count( $this->fields ); $i < $count; ++$i ) {
                     BP_XProfile_ProfileData::delete_for_field( $this->fields[$i]->id );
                 }
@@ -587 +587 @@
                         );
 
-                        $i++;
+                        ++$i;
                     }
                 }
 
                 if ( !empty( $options ) ) {
-                    for ( $i = 0; $i < count( $options ); $i++ ) {
+                    for ( $i = 0, $count = count( $options ); $i < $count; ++$i ) {
                         $j = $i + 1;
 
@@ -911 +911 @@
 
         if ( is_array( $fields ) ) {
-            for ( $i = 0; $i < count( $fields ); $i++ ) {
+            for ( $i = 0, $count = count( $fields ); $i < $count; ++$i ) {
                 if ( $i == 0 )
                     $field_sql .= $wpdb->prepare( "AND ( f.name = %s ", $fields[$i] );
@@ -931 +931 @@
 
         if ( is_array( $fields ) ) {
-            for ( $i = 0; $i < count( $values ); $i++ ) {
+            for ( $i = 0, $count = count( $values ); $i < $count; ++$i ) {
                 for ( $j = 0; $j < count( $fields ); $j++ ) {
                     if ( $values[$i]->name == $fields[$j] )