Changeset 4770 for trunk/bp-groups/bp-groups-classes.php

Timestamp:

07/21/2011 10:27:09 PM (13 years ago)

Author:

djpaul

Message:

Tune up 'for' loops. Fixes #2985, props cnorris23 and r-a-y

File:

• trunk/bp-groups/bp-groups-classes.php (modified) (3 diffs)

trunk/bp-groups/bp-groups-classes.php

@@ -542 +542 @@
         /* Fetch the logged in users status within each group */
         $user_status = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE user_id = %d AND group_id IN ( {$group_ids} ) AND is_confirmed = 1 AND is_banned = 0", $bp->loggedin_user->id ) );
-        for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
+        for ( $i = 0, $count = count( $paged_groups ); $i < $count; ++$i ) {
             $paged_groups[$i]->is_member = false;
 
@@ -552 +552 @@
 
         $user_banned = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE is_banned = 1 AND user_id = %d AND group_id IN ( {$group_ids} )", $bp->loggedin_user->id ) );
-        for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
+        for ( $i = 0, $count = count( $paged_groups ); $i < $count; ++$i ) {
             $paged_groups[$i]->is_banned = false;
 
@@ -1106 +1106 @@
         if ( bp_is_active( 'friends' ) ) {
             $friend_status = $wpdb->get_results( $wpdb->prepare( "SELECT initiator_user_id, friend_user_id, is_confirmed FROM {$bp->friends->table_name} WHERE (initiator_user_id = %d AND friend_user_id IN ( {$user_ids} ) ) OR (initiator_user_id IN ( {$user_ids} ) AND friend_user_id = %d )", $bp->loggedin_user->id, $bp->loggedin_user->id ) );
-            for ( $i = 0; $i < count( $members ); $i++ ) {
+            for ( $i = 0, $count = count( $members ); $i < $count; ++$i ) {
                 foreach ( (array)$friend_status as $status ) {
                     if ( $status->initiator_user_id == $members[$i]->user_id || $status->friend_user_id == $members[$i]->user_id )