Changeset 4770 for trunk/bp-forums/bp-forums-functions.php

Timestamp:

07/21/2011 10:27:09 PM (13 years ago)

Author:

djpaul

Message:

Tune up 'for' loops. Fixes #2985, props cnorris23 and r-a-y

File:

• trunk/bp-forums/bp-forums-functions.php (modified) (4 diffs)

trunk/bp-forums/bp-forums-functions.php

@@ -321 +321 @@
     // Fetch the topic's last poster details
     $poster_details = $wpdb->get_results( $wpdb->prepare( "SELECT t.topic_id, t.topic_last_poster, u.user_login, u.user_nicename, u.user_email, u.display_name FROM {$wpdb->users} u, {$bbdb->topics} t WHERE u.ID = t.topic_last_poster AND t.topic_id IN ( {$topic_ids} )" ) );
-    for ( $i = 0; $i < count( $topics ); $i++ ) {
+    for ( $i = 0, $count = count( $topics ); $i < $count; ++$i ) {
         foreach ( (array)$poster_details as $poster ) {
             if ( $poster->topic_id == $topics[$i]->topic_id ) {
@@ -335 +335 @@
     if ( bp_is_active( 'xprofile' ) ) {
         $poster_names = $wpdb->get_results( $wpdb->prepare( "SELECT t.topic_id, pd.value FROM {$bp->profile->table_name_data} pd, {$bbdb->topics} t WHERE pd.user_id = t.topic_last_poster AND pd.field_id = 1 AND t.topic_id IN ( {$topic_ids} )" ) );
-        for ( $i = 0; $i < count( $topics ); $i++ ) {
+        for ( $i = 0, $count = count( $topics ); $i < $count; ++$i ) {
             foreach ( (array)$poster_names as $name ) {
                 if ( $name->topic_id == $topics[$i]->topic_id )
@@ -439 +439 @@
     $poster_details = $wpdb->get_results( $wpdb->prepare( "SELECT u.ID as user_id, u.user_login, u.user_nicename, u.user_email, u.display_name FROM {$wpdb->users} u WHERE u.ID IN ( {$user_ids} )" ) );
 
-    for ( $i = 0; $i < count( $posts ); $i++ ) {
+    for ( $i = 0, $count = count( $posts ); $i < $count; ++$i ) {
         foreach ( (array)$poster_details as $poster ) {
             if ( $poster->user_id == $posts[$i]->poster_id ) {
@@ -453 +453 @@
     if ( bp_is_active( 'xprofile' ) ) {
         $poster_names = $wpdb->get_results( $wpdb->prepare( "SELECT pd.user_id, pd.value FROM {$bp->profile->table_name_data} pd WHERE pd.user_id IN ( {$user_ids} )" ) );
-        for ( $i = 0; $i < count( $posts ); $i++ ) {
+        for ( $i = 0, $count = count( $posts ); $i < $count; ++$i ) {
             foreach ( (array)$poster_names as $name ) {
                 if ( isset( $topics[$i] ) && $name->user_id == $topics[$i]->user_id )