Changeset 4380 for trunk/bp-core/bp-core-classes.php

Timestamp:

05/16/2011 10:41:52 PM (13 years ago)

Author:

boonebgorges

Message:

Additional bp_get_user_meta_key() applications in query classes, plus wpdb->prepare() cleanup. References #2952. Props nacin.

File:

• trunk/bp-core/bp-core-classes.php (modified) (5 diffs)

trunk/bp-core/bp-core-classes.php

@@ -149 +149 @@
 
         if ( 'popular' == $type )
-            $sql['where_popular'] = "AND um.meta_key = 'total_friend_count'";
+            $sql['where_popular'] = $wpdb->prepare( "AND um.meta_key = %s", bp_get_user_meta_key( 'total_friend_count' ) );
 
         if ( 'online' == $type )
@@ -390 +390 @@
         // Fetch the user's total friend count
         if ( 'popular' != $type ) {
-            $friend_count = $wpdb->get_results( "SELECT user_id as id, meta_value as total_friend_count FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = 'total_friend_count' AND user_id IN ( {$user_ids} )" );
+            $friend_count = $wpdb->get_results( $wpdb->prepare( "SELECT user_id as id, meta_value as total_friend_count FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = %s AND user_id IN ( {$user_ids} )", bp_get_user_meta_key( 'total_friend_count' ) ) );
             for ( $i = 0; $i < count( $paged_users ); $i++ ) {
                 foreach ( (array)$friend_count as $count ) {
@@ -411 +411 @@
 
         if ( 'active' != $type ) {
-            $user_activity = $wpdb->get_results( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = '" . bp_get_user_meta_key( 'last_activity' ) . "' AND user_id IN ( {$user_ids} )" );
+            $user_activity = $wpdb->get_results( $wpdb->prepare( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = %s AND user_id IN ( {$user_ids} )", bp_get_user_meta_key( 'last_activity' ) ) );
             for ( $i = 0; $i < count( $paged_users ); $i++ ) {
                 foreach ( (array)$user_activity as $activity ) {
@@ -422 +422 @@
         // Fetch the user's last_activity
         if ( 'active' != $type ) {
-            $user_activity = $wpdb->get_results( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = '" . bp_get_user_meta_key( 'last_activity' ) . "' AND user_id IN ( {$user_ids} )" );
+            $user_activity = $wpdb->get_results( $wpdb->prepare( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = %s AND user_id IN ( {$user_ids} )", bp_get_user_meta_key( 'last_activity' ) ) );
             for ( $i = 0; $i < count( $paged_users ); $i++ ) {
                 foreach ( (array)$user_activity as $activity ) {
@@ -432 +432 @@
 
         // Fetch the user's latest update
-        $user_update = $wpdb->get_results( "SELECT user_id as id, meta_value as latest_update FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = '" . bp_get_user_meta_key( 'bp_latest_update' ) . "' AND user_id IN ( {$user_ids} )" );
+        $user_update = $wpdb->get_results( $wpdb->prepare( "SELECT user_id as id, meta_value as latest_update FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = %s AND user_id IN ( {$user_ids} )", bp_get_user_meta_key( 'bp_latest_update' ) ) );
         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
             foreach ( (array)$user_update as $update ) {