Changeset 4242 for trunk/bp-messages/bp-messages-classes.php

Timestamp:

04/22/2011 09:33:48 PM (15 years ago)

Author:

djpaul

Message:

Create an array of user IDs for the in_array() check. Fixes #3167, props rebootnow

File:

• trunk/bp-messages/bp-messages-classes.php (modified) (1 diff)

trunk/bp-messages/bp-messages-classes.php

@@ -303 +303 @@
                         return false;
 
+                $recipient_ids = array();
+
                 if ( $new_thread ) {
                         // Add an recipient entry for all recipients
-                        foreach ( (array)$this->recipients as $recipient )
+                        foreach ( (array)$this->recipients as $recipient ) {
                                 $wpdb->query( $wpdb->prepare( "INSERT INTO {$bp->messages->table_name_recipients} ( user_id, thread_id, unread_count ) VALUES ( %d, %d, 1 )", $recipient->user_id, $this->thread_id ) );
+                                $recipient_ids[] = $recipient->user_id;
+                        }
 
                         // Add a sender recipient entry if the sender is not in the list of recipients
-                        if ( !in_array( $this->sender_id, $this->recipients ) )
+                        if ( !in_array( $this->sender_id, $recipient_ids ) )
                                 $wpdb->query( $wpdb->prepare( "INSERT INTO {$bp->messages->table_name_recipients} ( user_id, thread_id, sender_only ) VALUES ( %d, %d, 1 )", $this->sender_id, $this->thread_id ) );
                 } else {