Changeset 3903 for trunk/bp-activity/bp-activity-classes.php

Timestamp:

01/24/2011 01:17:29 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Full by-ref audit of all components. Sacrifice E_DEPRECATED notices in PHP 5.3 for PHP4.x compatibility.

See r3893, r3892, r3891, r3873, r3871, r3867, r3865, r3864, r3863, r3854.

File:

• trunk/bp-activity/bp-activity-classes.php (modified) (2 diffs)

trunk/bp-activity/bp-activity-classes.php

@@ -48 +48 @@
         global $wpdb, $bp, $current_user;
 
-        do_action( 'bp_activity_before_save', $this );
-
-        $this->id                = apply_filters( 'bp_activity_id_before_save',                $this->id,                $this );
-        $this->item_id           = apply_filters( 'bp_activity_item_id_before_save',           $this->item_id,           $this );
-        $this->secondary_item_id = apply_filters( 'bp_activity_secondary_item_id_before_save', $this->secondary_item_id, $this );
-        $this->user_id           = apply_filters( 'bp_activity_user_id_before_save',           $this->user_id,           $this );
-        $this->primary_link      = apply_filters( 'bp_activity_primary_link_before_save',      $this->primary_link,      $this );
-        $this->component         = apply_filters( 'bp_activity_component_before_save',         $this->component,         $this );
-        $this->type              = apply_filters( 'bp_activity_type_before_save',              $this->type,              $this );
-        $this->action            = apply_filters( 'bp_activity_action_before_save',            $this->action,            $this );
-        $this->content           = apply_filters( 'bp_activity_content_before_save',           $this->content,           $this );
-        $this->date_recorded     = apply_filters( 'bp_activity_date_recorded_before_save',     $this->date_recorded,     $this );
-        $this->hide_sitewide     = apply_filters( 'bp_activity_hide_sitewide_before_save',     $this->hide_sitewide,     $this );
-        $this->mptt_left         = apply_filters( 'bp_activity_mptt_left_before_save',         $this->mptt_left,         $this );
-        $this->mptt_right        = apply_filters( 'bp_activity_mptt_right_before_save',        $this->mptt_right,        $this );
+        // Use this...
+        do_action_ref_array( 'bp_activity_before_save', array( &$this ) );
+
+        // Not these.
+        $this->id                = apply_filters_ref_array( 'bp_activity_id_before_save',                array( $this->id,                &$this ) );
+        $this->item_id           = apply_filters_ref_array( 'bp_activity_item_id_before_save',           array( $this->item_id,           &$this ) );
+        $this->secondary_item_id = apply_filters_ref_array( 'bp_activity_secondary_item_id_before_save', array( $this->secondary_item_id, &$this ) );
+        $this->user_id           = apply_filters_ref_array( 'bp_activity_user_id_before_save',           array( $this->user_id,           &$this ) );
+        $this->primary_link      = apply_filters_ref_array( 'bp_activity_primary_link_before_save',      array( $this->primary_link,      &$this ) );
+        $this->component         = apply_filters_ref_array( 'bp_activity_component_before_save',         array( $this->component,         &$this ) );
+        $this->type              = apply_filters_ref_array( 'bp_activity_type_before_save',              array( $this->type,              &$this ) );
+        $this->action            = apply_filters_ref_array( 'bp_activity_action_before_save',            array( $this->action,            &$this ) );
+        $this->content           = apply_filters_ref_array( 'bp_activity_content_before_save',           array( $this->content,           &$this ) );
+        $this->date_recorded     = apply_filters_ref_array( 'bp_activity_date_recorded_before_save',     array( $this->date_recorded,     &$this ) );
+        $this->hide_sitewide     = apply_filters_ref_array( 'bp_activity_hide_sitewide_before_save',     array( $this->hide_sitewide,     &$this ) );
+        $this->mptt_left         = apply_filters_ref_array( 'bp_activity_mptt_left_before_save',         array( $this->mptt_left,         &$this ) );
+        $this->mptt_right        = apply_filters_ref_array( 'bp_activity_mptt_right_before_save',        array( $this->mptt_right,        &$this ) );
 
         if ( !$this->component || !$this->type )
@@ -82 +84 @@
             $this->id = $wpdb->insert_id;
 
-        do_action( 'bp_activity_after_save', $this );
+        do_action_ref_array( 'bp_activity_after_save', array( &$this ) );
+
         return true;
     }