Changeset 3660

Timestamp:

01/05/2011 10:03:41 PM (14 years ago)

Author:

djpaul

Message:

Speed up forum directory's "last active" bbPress SQL query to stop it fetching information we aren't using. Helps fix #2421

Location:

trunk

Files:

• bp-forums.php (modified) (4 diffs)
• bp-forums/bp-forums-filters.php (modified) (1 diff)
• bp-groups/bp-groups-filters.php (modified) (1 diff)

trunk/bp-forums.php

@@ -373 +373 @@
     do_action( 'bbpress_init' );
 
-    $count = $bbdb->get_results( $bbdb->prepare( "SELECT t.topic_id FROM {$bbdb->topics} AS t". groups_add_forum_tables_sql( '' ) . " WHERE " . groups_add_forum_where_sql( "t.topic_status = '0'" ) ) );
+    $count = $bbdb->get_results( $bbdb->prepare( "SELECT t.topic_id FROM {$bbdb->topics} AS t". groups_add_forum_tables_sql( '' ) . " WHERE " . groups_add_forum_where_sql( "t.topic_status = 0" ) ) );
     return apply_filters( 'bp_forums_total_topic_count', count( (array)$count ) );
 }
@@ -547 +547 @@
 }
 
-
 function bp_forums_get_forum_topicpost_count( $forum_id ) {
     global $wpdb, $bbdb;
@@ -556 +555 @@
     return $wpdb->get_results( $wpdb->prepare( "SELECT topics, posts from {$bbdb->forums} WHERE forum_id = %d", $forum_id ) );
 }
-
 
 function bp_forums_filter_caps( $allcaps ) {
@@ -589 +587 @@
 add_action( 'bp_forums_new_topic', 'bp_core_clear_cache' );
 add_action( 'bp_forums_new_post', 'bp_core_clear_cache' );
-
 ?>

trunk/bp-forums/bp-forums-filters.php

@@ -132 +132 @@
 add_filter( 'bp_get_the_topic_post_edit_text', 'bp_forums_strip_mentions_on_post_edit' );
 add_filter( 'bp_get_the_topic_text', 'bp_forums_strip_mentions_on_post_edit' );
-
 ?>

trunk/bp-groups/bp-groups-filters.php

@@ -106 +106 @@
 add_filter( 'bb_current_user_can', 'groups_filter_bbpress_caps', 10, 3 );
 
+/**
+ * Amends the forum directory's "last active" bbPress SQL query to stop it fetching
+ * information we aren't going to use. This speeds up the query.
+ *
+ * @see BB_Query::_filter_sql()
+ * @since 1.3
+ */
+function groups_filter_forums_root_page_sql( $sql ) {
+    return apply_filters( 'groups_filter_bbpress_root_page_sql', 't.topic_id' );
+}
+add_filter( 'get_latest_topics_fields', 'groups_filter_forums_root_page_sql' );
 ?>