Changeset 3511 for trunk/bp-blogs/bp-blogs-templatetags.php

Timestamp:

12/04/2010 11:41:28 PM (14 years ago)

Author:

djpaul

Message:

Fix double-escaping of search string when performing search from the site-wide search box. Partially addresses #2776.

File:

• trunk/bp-blogs/bp-blogs-templatetags.php (modified) (1 diff)

trunk/bp-blogs/bp-blogs-templatetags.php

@@ -503 +503 @@
 
 function bp_directory_blogs_search_form() {
-    global $bp; ?>
+    global $bp;
+
+    $search_value = __( 'Search anything...', 'buddypress' );
+    if ( !empty( $_GET['s'] ) )
+        $search_value = stripslashes( $_GET['s'] );
+
+    ?>
     <form action="" method="get" id="search-blogs-form">
-        <label><input type="text" name="s" id="blogs_search" value="<?php if ( isset( $_GET['s'] ) ) { echo $_GET['s']; } else { _e( 'Search anything...', 'buddypress' ); } ?>"  onfocus="if (this.value == '<?php _e( 'Search anything...', 'buddypress' ) ?>') {this.value = '';}" onblur="if (this.value == '') {this.value = '<?php _e( 'Search anything...', 'buddypress' ) ?>';}" /></label>
+        <label><input type="text" name="s" id="blogs_search" value="<?php echo esc_attr( $search_value ) ?>"  onfocus="if (this.value == '<?php _e( 'Search anything...', 'buddypress' ) ?>') {this.value = '';}" onblur="if (this.value == '') {this.value = '<?php _e( 'Search anything...', 'buddypress' ) ?>';}" /></label>
         <input type="submit" id="blogs_search_submit" name="blogs_search_submit" value="<?php _e( 'Search', 'buddypress' ) ?>" />
     </form>