Changeset 2824

Timestamp:

03/10/2010 11:11:55 AM (16 years ago)

Author:

apeatling

Message:

Fixed issue with non required fields not saving values correctly.

File:

• branches/1.2/bp-xprofile.php (modified) (3 diffs)

branches/1.2/bp-xprofile.php

@@ -322 +322 @@
                 }
 
-                if ( $errors )
+                if ( !empty( $errors ) )
                         bp_core_add_message( __( 'Please make sure you fill in all required fields in this profile field group before saving.', 'buddypress' ), 'error' );
                 else {
@@ -725 +725 @@
                 return false;
 
+        /* If the value is empty, then delete any field data that exists */
+        if ( empty( $value ) ) {
+                xprofile_delete_field_data( $field_id, $user_id );
+                return true;
+        }
+
         $field = new BP_XProfile_Field( $field_id );
 
@@ -765 +771 @@
                 $field_id = xprofile_get_field_id_from_name( $field );
 
-        if ( !$field_id )
-                return false;
-
-        $field = new BP_XProfile_ProfileData( $field_id );
+        if ( empty( $field_id ) || empty( $user_id ) )
+                return false;
+
+        $field = new BP_XProfile_ProfileData( $field_id, $user_id );
         return $field->delete();
 }