Changeset 2695 for trunk/bp-core/bp-core-widgets.php

Timestamp:

02/12/2010 12:31:49 PM (15 years ago)

Author:

apeatling

Message:

Fixing the use of deprecated template tags in bp-default. Merged the fetching of BP runtime settings into one query to significantly reduce the number of run time database hits. Fixed #1916

File:

• trunk/bp-core/bp-core-widgets.php (modified) (4 diffs)

trunk/bp-core/bp-core-widgets.php

@@ -87 +87 @@
            . $after_title; ?>
 
-        <?php if ( bp_has_members( 'user_id=0&type=newest&max=' . $instance['max_members'] ) ) : ?>
+        <?php if ( bp_has_members( 'user_id=0&type=newest&max=' . $instance['max_members'] . '&populate_extras=0' ) ) : ?>
             <div class="item-options" id="members-list-options">
                 <span class="ajax-loader" id="ajax-loader-members"></span>
@@ -255 +255 @@
     global $bp;
 
-    check_ajax_referer('bp_core_widget_members');
+    check_ajax_referer( 'bp_core_widget_members' );
 
     switch ( $_POST['filter'] ) {
@@ -267 +267 @@
             $type = 'popular';
         break;
-    } ?>
-    <?php if ( bp_has_members( 'user_id=0&type=' . $type . '&per_page=' . $_POST['max-members'] . '&max=' . $_POST['max-members'] ) ) : ?>
-        <?php echo '0[[SPLIT]]'; // return valid result. TODO: remove this because it's dumb. ?>
+    }
+
+    if ( bp_has_members( 'user_id=0&type=' . $type . '&per_page=' . $_POST['max-members'] . '&max=' . $_POST['max-members'] . '&populate_extras=0' ) ) : ?>
+        <?php echo '0[[SPLIT]]'; // return valid result. TODO: remove this. ?>
         <div class="avatar-block">
             <?php while ( bp_members() ) : bp_the_member(); ?>
@@ -279 +280 @@
                     <div class="item">
                         <div class="item-title fn"><a href="<?php bp_member_permalink() ?>" title="<?php bp_member_name() ?>"><?php bp_member_name() ?></a></div>
-                        <?php if ( 'active' == $type ) : ?>
+                        <?php if ( 'active' == $type || 'newest' == $type ) : ?>
                             <div class="item-meta"><span class="activity"><?php bp_member_last_active() ?></span></div>
                         <?php else : ?>