Changeset 2695 for trunk/bp-core/bp-core-classes.php

Timestamp:

02/12/2010 12:31:49 PM (15 years ago)

Author:

apeatling

Message:

Fixing the use of deprecated template tags in bp-default. Merged the fetching of BP runtime settings into one query to significantly reduce the number of run time database hits. Fixed #1916

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -207 +207 @@
          * We can't add these to the main query above since only users who have this information will be returned (since the much of the data is in usermeta and won't support any type of directional join)
          */
-        foreach ( (array)$paged_users as $user )
-            $user_ids[] = $user->id;
-
-        $user_ids = $wpdb->escape( join( ',', (array)$user_ids ) );
-
-        /* Add additional data to the returned results */
-        if ( $populate_extras )
+        if ( $populate_extras ) {
+            foreach ( (array)$paged_users as $user )
+                $user_ids[] = $user->id;
+
+            $user_ids = $wpdb->escape( join( ',', (array)$user_ids ) );
+
+            /* Add additional data to the returned results */
             $paged_users = BP_Core_User::get_user_extras( &$paged_users, $user_ids, $type );
+        }
 
         return array( 'users' => $paged_users, 'total' => $total_users );