Changeset 2576

Timestamp:

02/03/2010 09:06:27 PM (17 years ago)

Author:

apeatling

Message:

Fixes #1551 - also safeguarded all foreach loops with an array typecast.

Location:

trunk

Files:

• bp-activity/bp-activity-classes.php (modified) (4 diffs)
• bp-activity/bp-activity-templatetags.php (modified) (3 diffs)
• bp-blogs.php (modified) (1 diff)
• bp-blogs/bp-blogs-classes.php (modified) (3 diffs)
• bp-blogs/bp-blogs-templatetags.php (modified) (1 diff)
• bp-blogs/bp-blogs-widgets.php (modified) (1 diff)
• bp-core.php (modified) (6 diffs)
• bp-core/bp-core-activation.php (modified) (1 diff)
• bp-core/bp-core-admin.php (modified) (2 diffs)
• bp-core/bp-core-adminbar.php (modified) (4 diffs)
• bp-core/bp-core-classes.php (modified) (11 diffs)
• bp-core/bp-core-notifications.php (modified) (1 diff)
• bp-core/bp-core-settings.php (modified) (1 diff)
• bp-core/bp-core-signup.php (modified) (2 diffs)
• bp-core/bp-core-templatetags.php (modified) (2 diffs)
• bp-forums.php (modified) (3 diffs)
• bp-forums/bp-forums-admin.php (modified) (2 diffs)
• bp-groups.php (modified) (3 diffs)
• bp-groups/bp-groups-classes.php (modified) (12 diffs)
• bp-groups/bp-groups-notifications.php (modified) (1 diff)
• bp-groups/bp-groups-templatetags.php (modified) (6 diffs)
• bp-messages.php (modified) (1 diff)
• bp-messages/bp-messages-classes.php (modified) (4 diffs)
• bp-themes/bp-default/_inc/ajax.php (modified) (2 diffs)
• bp-themes/bp-default/_inc/global.js (modified) (1 diff)
• bp-themes/bp-default/comments.php (modified) (2 diffs)
• bp-themes/bp-sn-parent/_inc/ajax.php (modified) (1 diff)
• bp-xprofile.php (modified) (2 diffs)
• bp-xprofile/bp-xprofile-classes.php (modified) (1 diff)
• bp-xprofile/bp-xprofile-filters.php (modified) (3 diffs)

trunk/bp-activity/bp-activity-classes.php

@@ -319 +319 @@
 
                 /* Now fetch the activity comments and parse them into the correct position in the activities array. */
-                foreach( $activities as $activity ) {
+                foreach( (array)$activities as $activity ) {
                         if ( 'activity_comment' != $activity->type && $activity->mptt_left && $activity->mptt_right )
                                 $activity_comments[$activity->id] = BP_Activity_Activity::get_activity_comments( $activity->id, $activity->mptt_left, $activity->mptt_right );
@@ -325 +325 @@
 
                 /* Merge the comments with the activity items */
-                foreach( $activities as $key => $activity )
+                foreach( (array)$activities as $key => $activity )
                         $activities[$key]->children = $activity_comments[$activity->id];
 
@@ -345 +345 @@
 
                 /* Loop descendants and build an assoc array */
-                foreach ( $descendants as $d ) {
+                foreach ( (array)$descendants as $d ) {
                     $d->children = array();
 
@@ -373 +373 @@
 
                 /* Loop the descendants and recalculate the left and right values */
-                foreach ( $descendants as $descendant )
+                foreach ( (array)$descendants as $descendant )
                         $right = BP_Activity_Activity::rebuild_activity_comment_tree( $descendant->id, $right );
 

trunk/bp-activity/bp-activity-templatetags.php

@@ -502 +502 @@
                 $parent_activity = false;
 
-                foreach( $activities_template->activities as $activity ) {
+                foreach( (array)$activities_template->activities as $activity ) {
                         if ( $parent_id == $activity->id ) {
                                 /* Need a copy not a reference, this was the only PHP4 compat way I could find. */
@@ -563 +563 @@
 
                         $content .= '<ul>';
-                        foreach ( $comment->children as $comment ) {
+                        foreach ( (array)$comment->children as $comment ) {
                                 if ( !$comment->user_fullname )
                                         $comment->user_fullname = $comment->display_name;
@@ -609 +609 @@
                                 return $count;
 
-                        foreach ( $comment->children as $comment ) {
+                        foreach ( (array)$comment->children as $comment ) {
                                 $count++;
                                 $count = bp_activity_recurse_comment_count( $comment, $count );

trunk/bp-blogs.php

@@ -322 +322 @@
 
         if ( $blog_ids ) {
-                foreach( $blog_ids as $blog_id ) {
+                foreach( (array)$blog_ids as $blog_id ) {
                         $users = get_users_of_blog( $blog_id );
 
                         if ( $users ) {
-                                foreach ( $users as $user ) {
+                                foreach ( (array)$users as $user ) {
                                         $role = unserialize( $user->meta_value );
 

trunk/bp-blogs/bp-blogs-classes.php

@@ -102 +102 @@
                 if ( !empty( $search_terms ) ) {
                         $filter = like_escape( $wpdb->escape( $search_terms ) );
-                        $paged_blogs = $wpdb->get_results( $wpdb->prepare( "SELECT b.blog_id, b.user_id as admin_user_id, u.user_email as admin_user_email, wb.domain, wb.path, bm.meta_value as last_activity, bm2.meta_value as name, bm3.meta_value as description FROM {$bp->blogs->table_name} b, {$bp->blogs->table_name_blogmeta} bm, {$bp->blogs->table_name_blogmeta} bm2, {$bp->blogs->table_name_blogmeta} bm3, {$wpdb->base_prefix}blogs wb, {$wpdb->users} u WHERE b.blog_id = wb.blog_id AND b.user_id = u.ID AND b.blog_id = bm.blog_id AND b.blog_id = bm2.blog_id AND b.blog_id = bm3.blog_id AND wb.archived = '0' AND wb.spam = 0 AND wb.mature = 0 AND wb.deleted = 0 {$hidden_sql} AND bm.meta_key = 'last_activity' AND bm2.meta_key = 'name' AND bm3.meta_key = 'description' AND ( bm2.meta_value LIKE '%%$filter%%' || bm3.meta_value LIKE '%%$filter%%' ) {$user_sql} {$order_sql} {$pag_sql}" ) );
-                        $total_blogs = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT b.blog_id) FROM {$bp->blogs->table_name} b, {$wpdb->base_prefix}blogs wb, {$bp->blogs->table_name_blogmeta} bm, {$bp->blogs->table_name_blogmeta} bm2 WHERE b.blog_id = wb.blog_id AND bm.blog_id = b.blog_id AND bm2.blog_id = b.blog_id AND wb.archived = '0' AND wb.spam = 0 AND wb.mature = 0 AND wb.deleted = 0 {$hidden_sql} AND bm.meta_key = 'name' AND bm2.meta_key = 'description' AND ( bm.meta_value LIKE '%%$filter%%' || bm2.meta_value LIKE '%%$filter%%' ) {$user_sql}" ) );
+                        $paged_blogs = $wpdb->get_results( "SELECT b.blog_id, b.user_id as admin_user_id, u.user_email as admin_user_email, wb.domain, wb.path, bm.meta_value as last_activity, bm2.meta_value as name, bm3.meta_value as description FROM {$bp->blogs->table_name} b, {$bp->blogs->table_name_blogmeta} bm, {$bp->blogs->table_name_blogmeta} bm2, {$bp->blogs->table_name_blogmeta} bm3, {$wpdb->base_prefix}blogs wb, {$wpdb->users} u WHERE b.blog_id = wb.blog_id AND b.user_id = u.ID AND b.blog_id = bm.blog_id AND b.blog_id = bm2.blog_id AND b.blog_id = bm3.blog_id AND wb.archived = '0' AND wb.spam = 0 AND wb.mature = 0 AND wb.deleted = 0 {$hidden_sql} AND bm.meta_key = 'last_activity' AND bm2.meta_key = 'name' AND bm3.meta_key = 'description' AND ( bm2.meta_value LIKE '%%$filter%%' || bm3.meta_value LIKE '%%$filter%%' ) {$user_sql} {$order_sql} {$pag_sql}" );
+                        $total_blogs = $wpdb->get_var( "SELECT COUNT(DISTINCT b.blog_id) FROM {$bp->blogs->table_name} b, {$wpdb->base_prefix}blogs wb, {$bp->blogs->table_name_blogmeta} bm, {$bp->blogs->table_name_blogmeta} bm2 WHERE b.blog_id = wb.blog_id AND bm.blog_id = b.blog_id AND bm2.blog_id = b.blog_id AND wb.archived = '0' AND wb.spam = 0 AND wb.mature = 0 AND wb.deleted = 0 {$hidden_sql} AND bm.meta_key = 'name' AND bm2.meta_key = 'description' AND ( bm.meta_value LIKE '%%$filter%%' || bm2.meta_value LIKE '%%$filter%%' ) {$user_sql}" );
                 } else {
                         $paged_blogs = $wpdb->get_results( $wpdb->prepare( "SELECT b.blog_id, b.user_id as admin_user_id, u.user_email as admin_user_email, wb.domain, wb.path, bm.meta_value as last_activity, bm2.meta_value as name, bm3.meta_value as description FROM {$bp->blogs->table_name} b, {$bp->blogs->table_name_blogmeta} bm, {$bp->blogs->table_name_blogmeta} bm2, {$bp->blogs->table_name_blogmeta} bm3, {$wpdb->base_prefix}blogs wb, {$wpdb->users} u WHERE b.blog_id = wb.blog_id AND b.user_id = u.ID AND b.blog_id = bm.blog_id AND b.blog_id = bm2.blog_id AND b.blog_id = bm3.blog_id {$user_sql} AND wb.archived = '0' AND wb.spam = 0 AND wb.mature = 0 AND wb.deleted = 0 {$hidden_sql} AND bm.meta_key = 'last_activity' AND bm2.meta_key = 'name' AND bm3.meta_key = 'description' {$order_sql} {$pag_sql}" ) );
@@ -109 +109 @@
                 }
 
-                foreach ( $paged_blogs as $blog ) $blog_ids[] = $blog->blog_id;
+                foreach ( (array)$paged_blogs as $blog ) $blog_ids[] = $blog->blog_id;
                 $blog_ids = $wpdb->escape( join( ',', (array)$blog_ids ) );
                 $paged_blogs = BP_Blogs_Blog::get_blog_extras( &$paged_blogs, $blog_ids, $type );
@@ -284 +284 @@
 
                 for ( $i = 0; $i < count( $paged_blogs ); $i++ ) {
-                        foreach ( $post_ids as $post ) {
+                        foreach ( (array)$post_ids as $post ) {
                                 if ( $post->blog_id == $paged_blogs[$i]->blog_id ) {
                                         $paged_blogs[$i]->latest_post = $wpdb->get_row( "SELECT post_title, guid FROM {$wpdb->base_prefix}" . $post->blog_id . "_posts WHERE post_status = 'publish' AND post_type = 'post' ORDER BY id DESC LIMIT 1" );

trunk/bp-blogs/bp-blogs-templatetags.php

@@ -746 +746 @@
                 return false;
 
-        foreach ( $terms as $term ) {
+        foreach ( (array)$terms as $term ) {
                 $link = get_blog_option( BP_ROOT_BLOG, 'siteurl') . '/tag/' . $term->slug;
                 $link = apply_filters('term_link', $link);

trunk/bp-blogs/bp-blogs-widgets.php

@@ -34 +34 @@
                         </div>
                         <ul id="recent-posts" class="item-list">
-                                <?php foreach ( $posts as $post ) : ?>
+                                <?php foreach ( (array)$posts as $post ) : ?>
                                         <li>
                                                 <div class="item-avatar">

trunk/bp-core.php

@@ -730 +730 @@
                 return false;
 
-        foreach ( $bp->bp_nav as $slug => $nav_item ) {
+        foreach ( (array)$bp->bp_nav as $slug => $nav_item ) {
                 if ( empty( $temp[$nav_item['position']]) )
                         $temp[$nav_item['position']] = $nav_item;
@@ -809 +809 @@
                 return false;
 
-        foreach ( $bp->bp_options_nav as $parent_slug => $subnav_items ) {
+        foreach ( (array)$bp->bp_options_nav as $parent_slug => $subnav_items ) {
                 if ( !is_array( $subnav_items ) )
                         continue;
 
-                foreach ( $subnav_items as $subnav_item ) {
+                foreach ( (array)$subnav_items as $subnav_item ) {
                         if ( empty( $temp[$subnav_item['position']]) )
                                 $temp[$subnav_item['position']] = $subnav_item;
@@ -847 +847 @@
         /* Unset subnav items for this nav item */
         if ( is_array( $bp->bp_options_nav[$parent_id] ) ) {
-                foreach( $bp->bp_options_nav[$parent_id] as $subnav_item ) {
+                foreach( (array)$bp->bp_options_nav[$parent_id] as $subnav_item ) {
                         bp_core_remove_subnav_item( $parent_id, $subnav_item['slug'] );
                 }
@@ -1582 +1582 @@
 
         if ( is_array( $current ) ) {
-                foreach( $bp_illegal_names as $bp_illegal_name ) {
+                foreach( (array)$bp_illegal_names as $bp_illegal_name ) {
                         if ( !in_array( $bp_illegal_name, $current ) )
                                 $current[] = $bp_illegal_name;
@@ -2007 +2007 @@
         global $wpdb;
 
-        foreach( $comments as $comment ) {
+        foreach( (array)$comments as $comment ) {
                 if ( $comment->user_id )
                         $user_ids[] = $comment->user_id;
@@ -2020 +2020 @@
                 return $comments;
 
-        foreach( $userdata as $user )
+        foreach( (array)$userdata as $user )
                 $users[$user->user_id] = bp_core_get_user_domain( $user->user_id, $user->user_nicename, $user->user_login );
 
-        foreach( $comments as $i => $comment ) {
+        foreach( (array)$comments as $i => $comment ) {
                 if ( !empty( $comment->user_id ) ) {
                         if ( !empty( $users[$comment->user_id] ) )

trunk/bp-core/bp-core-activation.php

@@ -31 +31 @@
                                 $profile_field_ids = explode( ',', $signup['meta']['profile_field_ids'] );
 
-                                foreach( $profile_field_ids as $field_id ) {
+                                foreach( (array)$profile_field_ids as $field_id ) {
                                         $current_field = $signup['meta']["field_{$field_id}"];
 

trunk/bp-core/bp-core-admin.php

@@ -11 +11 @@
 
                 // Settings form submitted, now save the settings.
-                foreach ( $_POST['bp-admin'] as $key => $value ) {
+                foreach ( (array)$_POST['bp-admin'] as $key => $value ) {
 
                         if ( function_exists( 'xprofile_install' ) ) {
@@ -144 +144 @@
 
                 // Settings form submitted, now save the settings.
-                foreach ( $_POST['bp_components'] as $key => $value ) {
+                foreach ( (array)$_POST['bp_components'] as $key => $value ) {
                         if ( !(int) $value )
                                 $disabled[$key] = 1;

trunk/bp-core/bp-core-adminbar.php

@@ -61 +61 @@
         /* Loop through each navigation item */
         $counter = 0;
-        foreach( $bp->bp_nav as $nav_item ) {
+        foreach( (array)$bp->bp_nav as $nav_item ) {
                 $alt = ( 0 == $counter % 2 ) ? ' class="alt"' : '';
 
@@ -71 +71 @@
                         $sub_counter = 0;
 
-                        foreach( $bp->bp_options_nav[$nav_item['slug']] as $subnav_item ) {
+                        foreach( (array)$bp->bp_options_nav[$nav_item['slug']] as $subnav_item ) {
                                 $alt = ( 0 == $sub_counter % 2 ) ? ' class="alt"' : '';
                                 echo '<li' . $alt . '><a id="bp-admin-' . $subnav_item['css_id'] . '" href="' . $subnav_item['link'] . '">' . $subnav_item['name'] . '</a></li>';
@@ -112 +112 @@
         if ( is_array( $blogs['blogs'] ) && (int)$blogs['count'] ) {
                 $counter = 0;
-                foreach ( $blogs['blogs'] as $blog ) {
+                foreach ( (array)$blogs['blogs'] as $blog ) {
                         $alt = ( 0 == $counter % 2 ) ? ' class="alt"' : '';
 
@@ -192 +192 @@
 
                 echo '<ul class="author-list">';
-                foreach( $authors as $author ) {
+                foreach( (array)$authors as $author ) {
                         $author = new BP_Core_User( $author->user_id );
                         echo '<li>';

trunk/bp-core/bp-core-classes.php

@@ -181 +181 @@
 
                 /* Get paginated results */
-                $paged_users = $wpdb->get_results( $wpdb->prepare( join( ' ', (array)$sql ) ) );
+                $paged_users = $wpdb->get_results( join( ' ', (array)$sql ) );
 
                 /* Re-jig the SQL so we can get the total user count */
@@ -201 +201 @@
 
                 /* Get total user results */
-                $total_users = $wpdb->get_var( $wpdb->prepare( join( ' ', (array)$sql ) ) );
+                $total_users = $wpdb->get_var( join( ' ', (array)$sql ) );
 
                 /***
@@ -207 +207 @@
                  * We can't add these to the main query above since only users who have this information will be returned (since the much of the data is in usermeta and won't support any type of directional join)
                  */
-                foreach ( $paged_users as $user )
+                foreach ( (array)$paged_users as $user )
                         $user_ids[] = $user->id;
 
@@ -241 +241 @@
                  * We can't add these to the main query above since only users who have this information will be returned (since the much of the data is in usermeta and won't support any type of directional join)
                  */
-                foreach ( $paged_users as $user )
+                foreach ( (array)$paged_users as $user )
                         $user_ids[] = $user->id;
 
@@ -300 +300 @@
                  * We can't add these to the main query above since only users who have this information will be returned (since the much of the data is in usermeta and won't support any type of directional join)
                  */
-                foreach ( $paged_users as $user )
+                foreach ( (array)$paged_users as $user )
                         $user_ids[] = $user->id;
 
@@ -322 +322 @@
                         $names = $wpdb->get_results( $wpdb->prepare( "SELECT pd.user_id as id, pd.value as fullname FROM {$bp->profile->table_name_fields} pf, {$bp->profile->table_name_data} pd WHERE pf.id = pd.field_id AND pf.name = %s AND pd.user_id IN ( {$user_ids} )", BP_XPROFILE_FULLNAME_FIELD_NAME ) );
                         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                                foreach ( $names as $name ) {
+                                foreach ( (array)$names as $name ) {
                                         if ( $name->id == $paged_users[$i]->id )
                                                 $paged_users[$i]->fullname = $name->fullname;
@@ -333 +333 @@
                         $friend_count = $wpdb->get_results( "SELECT user_id as id, meta_value as total_friend_count FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = 'total_friend_count' AND user_id IN ( {$user_ids} )" );
                         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                                foreach ( $friend_count as $count ) {
+                                foreach ( (array)$friend_count as $count ) {
                                         if ( $count->id == $paged_users[$i]->id )
                                                 $paged_users[$i]->total_friend_count = (int)$count->total_friend_count;
@@ -344 +344 @@
                         $friend_status = $wpdb->get_results( $wpdb->prepare( "SELECT initiator_user_id, friend_user_id, is_confirmed FROM {$bp->friends->table_name} WHERE (initiator_user_id = %d AND friend_user_id IN ( {$user_ids} ) ) OR (initiator_user_id IN ( {$user_ids} ) AND friend_user_id = %d )", $bp->loggedin_user->id, $bp->loggedin_user->id ) );
                         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                                foreach ( $friend_status as $status ) {
+                                foreach ( (array)$friend_status as $status ) {
                                         if ( $status->initiator_user_id == $paged_users[$i]->id || $status->friend_user_id == $paged_users[$i]->id )
                                                 $paged_users[$i]->is_friend = $status->is_confirmed;
@@ -354 +354 @@
                         $user_activity = $wpdb->get_results( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = 'last_activity' AND user_id IN ( {$user_ids} )" );
                         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                                foreach ( $user_activity as $activity ) {
+                                foreach ( (array)$user_activity as $activity ) {
                                         if ( $activity->id == $paged_users[$i]->id )
                                                 $paged_users[$i]->last_activity = $activity->last_activity;
@@ -365 +365 @@
                         $user_activity = $wpdb->get_results( "SELECT user_id as id, meta_value as last_activity FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = 'last_activity' AND user_id IN ( {$user_ids} )" );
                         for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                                foreach ( $user_activity as $activity ) {
+                                foreach ( (array)$user_activity as $activity ) {
                                         if ( $activity->id == $paged_users[$i]->id )
                                                 $paged_users[$i]->last_activity = $activity->last_activity;
@@ -375 +375 @@
                 $user_update = $wpdb->get_results( "SELECT user_id as id, meta_value as latest_update FROM " . CUSTOM_USER_META_TABLE . " WHERE meta_key = 'bp_latest_update' AND user_id IN ( {$user_ids} )" );
                 for ( $i = 0; $i < count( $paged_users ); $i++ ) {
-                        foreach ( $user_update as $update ) {
+                        foreach ( (array)$user_update as $update ) {
                                 if ( $update->id == $paged_users[$i]->id )
                                         $paged_users[$i]->latest_update = $update->latest_update;

trunk/bp-core/bp-core-notifications.php

@@ -51 +51 @@
 
         /* Calculated a renderable outcome for each notification type */
-        foreach ( $grouped_notifications as $component_name => $action_arrays ) {
+        foreach ( (array)$grouped_notifications as $component_name => $action_arrays ) {
                 if ( !$action_arrays )
                         continue;
 
-                foreach ( $action_arrays as $component_action_name => $component_action_items ) {
+                foreach ( (array)$action_arrays as $component_action_name => $component_action_items ) {
                         $action_item_count = count($component_action_items);
 

trunk/bp-core/bp-core-settings.php

@@ -114 +114 @@
 
                 if ( $_POST['notifications'] ) {
-                        foreach ( $_POST['notifications'] as $key => $value ) {
+                        foreach ( (array)$_POST['notifications'] as $key => $value ) {
                                 update_usermeta( (int)$current_user->id, $key, $value );
                         }

trunk/bp-core/bp-core-signup.php

@@ -87 +87 @@
                 /* Add any errors to the action for the field in the template for display. */
                 if ( !empty( $bp->signup->errors ) ) {
-                        foreach ( $bp->signup->errors as $fieldname => $error_message )
+                        foreach ( (array)$bp->signup->errors as $fieldname => $error_message )
                                 add_action( 'bp_' . $fieldname . '_errors', create_function( '', 'echo "<div class=\"error\">' . $error_message . '</div>";' ) );
                 } else {
@@ -208 +208 @@
                         $profile_field_ids = explode( ',', $usermeta['profile_field_ids'] );
 
-                        foreach( $profile_field_ids as $field_id ) {
+                        foreach( (array)$profile_field_ids as $field_id ) {
                                 $current_field = $usermeta["field_{$field_id}"];
 

trunk/bp-core/bp-core-templatetags.php

@@ -501 +501 @@
         global $bp;
 
-        foreach ( $bp->bp_nav as $user_nav_item ) {
+        foreach ( (array)$bp->bp_nav as $user_nav_item ) {
                 if ( !$user_nav_item['show_for_displayed_user'] && !bp_is_my_profile() )
                         continue;
@@ -545 +545 @@
 
         /* Loop through each navigation item */
-        foreach ( $bp->bp_options_nav[$bp->current_component] as $subnav_item ) {
+        foreach ( (array)$bp->bp_options_nav[$bp->current_component] as $subnav_item ) {
                 if ( !$subnav_item['user_has_access'] )
                         continue;

trunk/bp-forums.php

@@ -341 +341 @@
 
         /* Get the topic ids */
-        foreach ( $topics as $topic ) $topic_ids[] = $topic->topic_id;
+        foreach ( (array)$topics as $topic ) $topic_ids[] = $topic->topic_id;
         $topic_ids = $wpdb->escape( join( ',', (array)$topic_ids ) );
 
@@ -347 +347 @@
         $poster_details = $wpdb->get_results( $wpdb->prepare( "SELECT t.topic_id, t.topic_last_poster, u.user_login, u.user_nicename, u.user_email, u.display_name FROM {$wpdb->users} u, {$bbdb->topics} t WHERE u.ID = t.topic_last_poster AND t.topic_id IN ( {$topic_ids} )" ) );
         for ( $i = 0; $i < count( $topics ); $i++ ) {
-                foreach ( $poster_details as $poster ) {
+                foreach ( (array)$poster_details as $poster ) {
                         if ( $poster->topic_id == $topics[$i]->topic_id ) {
                                 $topics[$i]->topic_last_poster_email = $poster->user_email;
@@ -361 +361 @@
                 $poster_names = $wpdb->get_results( $wpdb->prepare( "SELECT t.topic_id, pd.value FROM {$bp->profile->table_name_data} pd, {$bbdb->topics} t WHERE pd.user_id = t.topic_last_poster AND pd.field_id = 1 AND t.topic_id IN ( {$topic_ids} )" ) );
                 for ( $i = 0; $i < count( $topics ); $i++ ) {
-                        foreach ( $poster_names as $name ) {
+                        foreach ( (array)$poster_names as $name ) {
                                 if ( $name->topic_id == $topics[$i]->topic_id )
                                         $topics[$i]->topic_last_poster_displayname = $name->value;

trunk/bp-forums/bp-forums-admin.php

@@ -206 +206 @@
 
         // Loop through the lines and modify them
-        foreach ( $lines as $line ) {
+        foreach ( (array)$lines as $line ) {
                 if ( isset( $alterations[substr( $line, 0, 20 )] ) ) {
                         $alteration = $alterations[substr( $line, 0, 20 )];
@@ -239 +239 @@
 
         // Write lines one by one to avoid OS specific newline hassles
-        foreach ( $modified_lines as $modified_line ) {
+        foreach ( (array)$modified_lines as $modified_line ) {
                 if ( false !== strpos( $modified_line, '?>' ) ) {
                         $modified_line = '?>';

trunk/bp-groups.php

@@ -1129 +1129 @@
                          * we need to loop the step array and fetch the next step that way.
                          */
-                        foreach ( $bp->groups->group_creation_steps as $key => $value ) {
+                        foreach ( (array)$bp->groups->group_creation_steps as $key => $value ) {
                                 if ( $key == $bp->groups->current_create_step ) {
                                         $next = 1;
@@ -1203 +1203 @@
                 return false;
 
-        foreach ( $bp->groups->group_creation_steps as $slug => $step ) {
+        foreach ( (array)$bp->groups->group_creation_steps as $slug => $step ) {
                 while ( !empty( $temp[$step['position']] ) )
                         $step['position']++;
@@ -1214 +1214 @@
         unset($bp->groups->group_creation_steps);
 
-        foreach( $temp as $position => $step )
+        foreach( (array)$temp as $position => $step )
                 $bp->groups->group_creation_steps[$step['slug']] = array( 'name' => $step['name'], 'position' => $position );
 }

trunk/bp-groups/bp-groups-classes.php

@@ -273 +273 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY g.date_created DESC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY g.date_created DESC {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY g.date_created DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY g.date_created DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'newest' );
@@ -302 +303 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY last_activity DESC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY last_activity DESC {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY last_activity DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY last_activity DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'active' );
@@ -332 +334 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY CONVERT(gm1.meta_value, SIGNED) DESC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY CONVERT(gm1.meta_value, SIGNED) DESC {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY CONVERT(gm1.meta_value, SIGNED) DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY CONVERT(gm1.meta_value, SIGNED) DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'popular' );
@@ -361 +364 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY g.name ASC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY g.name ASC {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY g.name ASC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY g.name ASC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'alphabetical' );
@@ -394 +398 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY f.topics DESC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} ORDER BY f.topics DESC {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY f.topics DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql} ORDER BY f.topics DESC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.topics > 0 {$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'most_forum_topics' );
@@ -427 +432 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY f.posts ASC {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_results( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.posts > 0 {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.posts > 0 {$hidden_sql} {$search_sql} ORDER BY f.posts ASC {$pag_sql}"  ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY f.posts ASC {$pag_sql}" );
+                        $total_groups = $wpdb->get_results( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bp->groups->table_name_members} m, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.posts > 0 {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT DISTINCT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) AND f.posts > 0 {$hidden_sql} {$search_sql} ORDER BY f.posts ASC {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'most_forum_posts' );
@@ -503 +509 @@
                 $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND g.name LIKE '$letter%%' {$hidden_sql} {$search_sql} ORDER BY g.name ASC {$pag_sql}"  ) );
 
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'letter' );
@@ -525 +531 @@
 
                 if ( $user_id ) {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY rand() {$pag_sql}", $user_id ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = %d AND m.inviter_id = 0 AND m.is_banned = 0", $user_id ) );
-                } else {
-                        $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY rand() {$pag_sql}" ) );
-                        $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" ) );
-                }
-
-                foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+                        $user_id = $wpdb->escape( $user_id );
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0 ORDER BY rand() {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.inviter_id = 0 AND m.is_banned = 0" );
+                } else {
+                        $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} ORDER BY rand() {$pag_sql}" );
+                        $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql}" );
+                }
+
+                foreach ( (array)$paged_groups as $group ) $group_ids[] = $group->id;
                 $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
                 $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'random' );
@@ -548 +555 @@
                 $user_status = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE user_id = %d AND group_id IN ( {$group_ids} ) AND is_confirmed = 1 AND is_banned = 0", $bp->loggedin_user->id ) );
                 for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
-                        foreach ( $user_status as $group_id ) {
+                        foreach ( (array)$user_status as $group_id ) {
                                 if ( $group_id == $paged_groups[$i]->id )
                                         $paged_groups[$i]->is_member = true;
@@ -556 +563 @@
                 $user_banned = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE is_banned = 1 AND user_id = %d AND group_id IN ( {$group_ids} )", $bp->loggedin_user->id ) );
                 for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
-                        foreach ( $user_banned as $group_id ) {
+                        foreach ( (array)$user_banned as $group_id ) {
                                 if ( $group_id == $paged_groups[$i]->id )
                                         $paged_groups[$i]->is_banned = true;
@@ -989 +996 @@
 
                 /* Fetch whether or not the user is a friend */
-                foreach ( $members as $user ) $user_ids[] = $user->user_id;
+                foreach ( (array)$members as $user ) $user_ids[] = $user->user_id;
                 $user_ids = $wpdb->escape( join( ',', (array)$user_ids ) );
 
@@ -995 +1002 @@
                         $friend_status = $wpdb->get_results( $wpdb->prepare( "SELECT initiator_user_id, friend_user_id, is_confirmed FROM {$bp->friends->table_name} WHERE (initiator_user_id = %d AND friend_user_id IN ( {$user_ids} ) ) OR (initiator_user_id IN ( {$user_ids} ) AND friend_user_id = %d )", $bp->loggedin_user->id, $bp->loggedin_user->id ) );
                         for ( $i = 0; $i < count( $members ); $i++ ) {
-                                foreach ( $friend_status as $status ) {
+                                foreach ( (array)$friend_status as $status ) {
                                         if ( $status->initiator_user_id == $members[$i]->user_id || $status->friend_user_id == $members[$i]->user_id )
                                                 $members[$i]->is_friend = $status->is_confirmed;

trunk/bp-groups/bp-groups-notifications.php

@@ -8 +8 @@
 
         $user_ids = BP_Groups_Member::get_group_member_ids( $group->id );
-        foreach ( $user_ids as $user_id ) {
+        foreach ( (array)$user_ids as $user_id ) {
                 if ( 'no' == get_usermeta( $user_id, 'notification_groups_group_updated' ) ) continue;
 

trunk/bp-groups/bp-groups-templatetags.php

@@ -804 +804 @@
         <?php if ( $admins ) { ?>
                 <ul id="admins-list" class="item-list<?php if ( $admin_list ) { ?> single-line<?php } ?>">
-                <?php foreach ( $admins as $admin ) { ?>
+                <?php foreach ( (array)$admins as $admin ) { ?>
                         <?php if ( $admin_list ) { ?>
                         <li>
@@ -842 +842 @@
                 <?php if ( $group_mods ) { ?>
                         <ul id="mods-list" class="item-list<?php if ( $admin_list ) { ?> single-line<?php } ?>">
-                        <?php foreach ( $group_mods as $mod ) { ?>
+                        <?php foreach ( (array)$group_mods as $mod ) { ?>
                                 <?php if ( $admin_list ) { ?>
                                 <li>
@@ -1510 +1510 @@
         $counter = 1;
 
-        foreach ( $bp->groups->group_creation_steps as $slug => $step ) {
+        foreach ( (array)$bp->groups->group_creation_steps as $slug => $step ) {
                 $is_enabled = bp_are_previous_group_creation_steps_complete( $slug ); ?>
 
@@ -1573 +1573 @@
                 $found = true;
 
-                foreach ( $step_slugs as $step_slug ) {
+                foreach ( (array)$step_slugs as $step_slug ) {
                         if ( !in_array( $step_slug, $bp->groups->completed_create_steps ) )
                                 $found = false;
@@ -1597 +1597 @@
 
         /* Get previous steps */
-        foreach ( $bp->groups->group_creation_steps as $slug => $name ) {
+        foreach ( (array)$bp->groups->group_creation_steps as $slug => $name ) {
                 if ( $slug == $step_slug )
                         break;
@@ -1675 +1675 @@
                 global $bp;
 
-                foreach ( $bp->groups->group_creation_steps as $slug => $name ) {
+                foreach ( (array)$bp->groups->group_creation_steps as $slug => $name ) {
                         if ( $slug == $bp->action_variables[1] )
                                 break;

trunk/bp-messages.php

@@ -453 +453 @@
 
                 /* Format this to match existing recipients */
-                foreach( $recipient_ids as $i => $recipient_id ) {
+                foreach( (array)$recipient_ids as $i => $recipient_id ) {
                         $message->recipients[$i] = new stdClass;
                         $message->recipients[$i]->user_id = $recipient_id;

trunk/bp-messages/bp-messages-classes.php

@@ -46 +46 @@
                 $results = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$bp->messages->table_name_recipients} WHERE thread_id = %d", $this->thread_id ) );
 
-                foreach ( $results as $recipient )
+                foreach ( (array)$results as $recipient )
                         $recipients[$recipient->user_id] = $recipient;
 
@@ -97 +97 @@
 
                 /* Sort threads by date_sent */
-                foreach( $thread_ids as $thread ) {
+                foreach( (array)$thread_ids as $thread ) {
                         $sorted_threads[$thread->thread_id] = strtotime($thread->date_sent);
                 }
@@ -103 +103 @@
 
                 $threads = false;
-                foreach ( $sorted_threads as $thread_id => $date_sent )
+                foreach ( (array)$sorted_threads as $thread_id => $date_sent )
                         $threads[] = new BP_Messages_Thread( $thread_id );
 
@@ -193 +193 @@
                         return count( $recipients ) . __(' Recipients', 'buddypress');
 
-                foreach ( $recipients as $recipient ) {
+                foreach ( (array)$recipients as $recipient ) {
                         $recipient_links[] = bp_core_get_userlink( $recipient->user_id );
                 }

trunk/bp-themes/bp-default/_inc/ajax.php

@@ -246 +246 @@
         /* Add the new page param */
         $args = explode( '&', trim( $query_string ) );
-        foreach( $args as $arg ) {
+        foreach( (array)$args as $arg ) {
                 if ( false === strpos( $arg, 'page' ) )
                         $new_args[] = $arg;
@@ -544 +544 @@
 
         if ( $friends['friends'] ) {
-                foreach ( $friends['friends'] as $user_id ) {
+                foreach ( (array)$friends['friends'] as $user_id ) {
                         $ud = get_userdata($user_id);
                         $username = $ud->user_login;

trunk/bp-themes/bp-default/_inc/global.js

@@ -104 +104 @@
         /* List tabs event delegation */
         j('div.activity-type-tabs').click( function(event) {
-                var target = j(event.target).parent();
+                var target = j(event.target).parent().parent();
 
                 if ( event.target.nodeName != 'A' )

trunk/bp-themes/bp-default/comments.php

@@ -16 +16 @@
                         <?php
                         $numTrackBacks = 0; $numComments = 0;
-                        foreach ( $comments as $comment ) if ( get_comment_type() != "comment") $numTrackBacks++; else $numComments++;
+                        foreach ( (array)$comments as $comment ) if ( get_comment_type() != "comment") $numTrackBacks++; else $numComments++;
                         ?>
 
@@ -164 +164 @@
 
                                 <ul id="trackbacklist">
-                                        <?php foreach ( $comments as $comment ) : ?>
+                                        <?php foreach ( (array)$comments as $comment ) : ?>
 
                                                 <?php if ( get_comment_type() != 'comment' ) : ?>

trunk/bp-themes/bp-sn-parent/_inc/ajax.php

@@ -293 +293 @@
 
         if ( $friends['friends'] ) {
-                foreach ( $friends['friends'] as $user_id ) {
+                foreach ( (array)$friends['friends'] as $user_id ) {
                         $ud = get_userdata($user_id);
                         $username = $ud->user_login;

trunk/bp-xprofile.php

@@ -300 +300 @@
 
                 /* Loop through the posted fields formatting any datebox values then validate the field */
-                foreach ( $posted_field_ids as $field_id ) {
+                foreach ( (array)$posted_field_ids as $field_id ) {
                         if ( !isset( $_POST['field_' . $field_id] ) ) {
 
@@ -326 +326 @@
 
                         /* Now we've checked for required fields, lets save the values. */
-                        foreach ( $posted_field_ids as $field_id ) {
+                        foreach ( (array)$posted_field_ids as $field_id ) {
                                 if ( !xprofile_set_field_data( $field_id, $bp->displayed_user->id, $_POST['field_' . $field_id] ) )
                                         $errors = true;

trunk/bp-xprofile/bp-xprofile-classes.php

@@ -355 +355 @@
                                 $counter = 1;
                                 if ( $options ) {
-                                        foreach ( $options as $option_key => $option_value ) {
+                                        foreach ( (array)$options as $option_key => $option_value ) {
                                                 $is_default = 0;
 

trunk/bp-xprofile/bp-xprofile-filters.php

@@ -65 +65 @@
 
         if ( $values ) {
-                foreach ( $values as $value ) {
+                foreach ( (array)$values as $value ) {
                         $value = trim( $value );
 
@@ -86 +86 @@
 
 function xprofile_filter_comments( $comments, $post_id ) {
-        foreach( $comments as $comment ) {
+        foreach( (array)$comments as $comment ) {
                 if ( $comment->user_id )
                         $user_ids[] = $comment->user_id;
@@ -95 +95 @@
 
         if ( $fullnames = BP_XProfile_ProfileData::get_value_byid( 1, $user_ids ) ) {
-                foreach( $fullnames as $user ) {
+                foreach( (array)$fullnames as $user ) {
                         $users[$user->user_id] = trim($user->value);
                 }
         }
 
-        foreach( $comments as $i => $comment ) {
+        foreach( (array)$comments as $i => $comment ) {
                 if ( !empty( $comment->user_id ) ) {
                         if ( !empty( $users[$comment->user_id] ) )