Changeset 2533 for trunk/bp-groups/bp-groups-classes.php

Timestamp:

02/02/2010 12:40:49 PM (15 years ago)

Author:

apeatling

Message:

Removing database hits inside BP loops to improve overall performance.

File:

• trunk/bp-groups/bp-groups-classes.php (modified) (9 diffs)

trunk/bp-groups/bp-groups-classes.php

@@ -48 +48 @@
                 $this->user_dataset = $this->get_user_dataset();
 
-                //if ( !$this->total_member_count ) {
                 $this->total_member_count = count( $this->user_dataset );
                 groups_update_groupmeta( $this->id, 'total_member_count', $this->total_member_count );
-                //}
             }
+
+            /* Get group extras */
+            $this->is_member = BP_Groups_Member::check_is_member( $bp->loggedin_user->id, $this->id );
         }
     }
@@ -336 +337 @@
         }
 
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'newest' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -361 +365 @@
         }
 
+        foreach ( $paged_groups as $group ) $group_ids[] = $group->id;
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'active' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -387 +395 @@
         }
 
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'popular' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -412 +423 @@
         }
 
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'alphabetical' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -441 +455 @@
         }
 
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'most_forum_topics' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -469 +486 @@
             $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_groupmeta} gm3, {$bbdb->forums} f, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND g.id = gm3.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND (gm3.meta_key = 'forum_id' AND gm3.meta_value = f.forum_id) {$hidden_sql} {$search_sql}" ) );
         }
+
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'most_forum_posts' );
 
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
@@ -535 +555 @@
         $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND g.name LIKE '$letter%%' {$hidden_sql} {$search_sql} ORDER BY g.name ASC {$pag_sql}"  ) );
 
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'letter' );
+
         return array( 'groups' => $paged_groups, 'total' => $total_groups );
     }
@@ -560 +583 @@
         }
 
-        return array( 'groups' => $paged_groups, 'total' => $total_groups );
+        $group_ids = $wpdb->escape( join( ',', (array)$group_ids ) );
+        $paged_groups = BP_Groups_Group::get_group_extras( &$paged_groups, $group_ids, 'random' );
+
+        return array( 'groups' => $paged_groups, 'total' => $total_groups );
+    }
+
+    function get_group_extras( $paged_groups, $group_ids, $type = false ) {
+        global $bp, $wpdb;
+
+        if ( empty( $group_ids ) )
+            return $paged_groups;
+
+        /* Fetch the logged in users status within each group */
+        $user_status = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE user_id = %d AND group_id IN ( {$group_ids} ) AND is_confirmed = 1 AND is_banned = 0", $bp->loggedin_user->id ) );
+        for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
+            foreach ( $user_status as $group_id ) {
+                if ( $group_id == $paged_groups[$i]->id )
+                    $paged_groups[$i]->is_member = true;
+            }
+        }
+
+        $user_banned = $wpdb->get_col( $wpdb->prepare( "SELECT group_id FROM {$bp->groups->table_name_members} WHERE is_banned = 1 AND user_id = %d AND group_id IN ( {$group_ids} )", $bp->loggedin_user->id ) );
+        for ( $i = 0; $i < count( $paged_groups ); $i++ ) {
+            foreach ( $user_banned as $group_id ) {
+                if ( $group_id == $paged_groups[$i]->id )
+                    $paged_groups[$i]->is_banned = true;
+            }
+        }
+
+        return $paged_groups;
     }