Changeset 1503 for trunk/bp-groups.php

Timestamp:

06/03/2009 10:49:34 PM (16 years ago)

Author:

apeatling

Message:

Removed the use of sessions in BuddyPress, as this is not a robust solution when installed on a multi-server setup.

File:

• trunk/bp-groups.php (modified) (4 diffs)

trunk/bp-groups.php

@@ -362 +362 @@
         $completed_to_step = 0;
         
-        unset($_SESSION['group_obj_id']);
-        unset($_SESSION['completed_to_step']);
+        setcookie( 'bp_group_obj_id', false, time() - 1000, COOKIEPATH );
+        setcookie( 'bp_group_completed_to_step', false, time() - 1000, COOKIEPATH );
         
         $no_instantiate = true;
@@ -369 +369 @@
     }
     
-    if ( isset($_SESSION['completed_to_step']) && !$reset_steps ) {
-        $completed_to_step = $_SESSION['completed_to_step'];
+    if ( isset($_COOKIE['bp_group_completed_to_step']) && !$reset_steps ) {
+        $completed_to_step = $_COOKIE['bp_group_completed_to_step'];
     }
     
     if ( isset( $_POST['save'] ) || isset( $_POST['skip'] ) ) {
-        $group_obj = new BP_Groups_Group( $_SESSION['group_obj_id'] );
-
-        if ( !$group_id = groups_create_group( $create_group_step, $_SESSION['group_obj_id'] ) ) {
+        $group_obj = new BP_Groups_Group( $_COOKIE['bp_group_obj_id'] );
+
+        if ( !$group_id = groups_create_group( $create_group_step, $_COOKIE['bp_group_obj_id'] ) ) {
             bp_core_add_message( __('There was an error saving group details. Please try again.', 'buddypress'), 'error' );
             bp_core_redirect( $bp->loggedin_user->domain . $bp->groups->slug . '/create/step/' . $create_group_step );
@@ -382 +382 @@
             $create_group_step++;
             $completed_to_step++;
-            $_SESSION['completed_to_step'] = $completed_to_step;
-            $_SESSION['group_obj_id'] = $group_id;
+            
+            /* Unset cookie info */
+            setcookie( 'bp_group_obj_id', false, time() - 1000, COOKIEPATH );
+            setcookie( 'bp_group_completed_to_step', false, time() - 1000, COOKIEPATH );
+            
+            /* Reset cookie info */
+            setcookie( 'bp_group_obj_id', $group_id, time()+60*60*24, COOKIEPATH );
+            setcookie( 'bp_group_completed_to_step', $completed_to_step, time()+60*60*24, COOKIEPATH );
         }
         
@@ -390 +396 @@
     }
 
-    if ( isset($_SESSION['group_obj_id']) && !$group_obj && !$no_instantiate )
-        $group_obj = new BP_Groups_Group( $_SESSION['group_obj_id'] );
+    if ( isset($_COOKIE['bp_group_obj_id']) && !$group_obj && !$no_instantiate )
+        $group_obj = new BP_Groups_Group( $_COOKIE['bp_group_obj_id'] );
     
     bp_core_load_template( apply_filters( 'groups_template_create_group', 'groups/create' ) );