Changeset 1503 for trunk/bp-core.php

Timestamp:

06/03/2009 10:49:34 PM (16 years ago)

Author:

apeatling

Message:

Removed the use of sessions in BuddyPress, as this is not a robust solution when installed on a multi-server setup.

File:

• trunk/bp-core.php (modified) (4 diffs)

trunk/bp-core.php

@@ -1 +1 @@
 <?php
-
 /* Define the current version number for checking if DB tables are up to date. */
 define( 'BP_CORE_VERSION', '1.0' );
@@ -171 +170 @@
 add_action( 'plugins_loaded', 'bp_core_setup_root_components', 1 );
 
-function bp_core_setup_session() {
-    // Start a session for error/success feedback on redirect and for signup functions.
-    @session_start();
+function bp_core_setup_cookies() {
+    global $bp_message, $bp_message_type;
     
     // Render any error/success feedback on the template
-    if ( $_SESSION['message'] != '' )
-        add_action( 'template_notices', 'bp_core_render_notice' );
-}
-add_action( 'wp', 'bp_core_setup_session', 3 );
+    if ( $_COOKIE['bp-message'] == '' || !isset( $_COOKIE['bp-message'] ) )
+        return false;
+
+    $bp_message = $_COOKIE['bp-message'];
+    $bp_message_type = $_COOKIE['bp-message-type'];
+    add_action( 'template_notices', 'bp_core_render_notice' );
+
+    setcookie( 'bp-message', false, time() - 1000, COOKIEPATH );
+    setcookie( 'bp-message-type', false, time() - 1000, COOKIEPATH );
+}
+add_action( 'wp', 'bp_core_setup_cookies', 3 );
 
 function bp_core_install() {
@@ -847 +852 @@
     if ( !$type )
         $type = 'success';
-    
-    $_SESSION['message'] = $message;
-    $_SESSION['message_type'] = $type;
+
+    setcookie( 'bp-message', $message, time()+60*60*24, COOKIEPATH );
+    setcookie( 'bp-message-type', $type, time()+60*60*24, COOKIEPATH );
 }
 
@@ -862 +867 @@
  */
 function bp_core_render_notice() {
-    if ( $_SESSION['message'] ) {
-        $type = ( 'success' == $_SESSION['message_type'] ) ? 'updated' : 'error';
+    if ( $_COOKIE['bp-message'] ) {
+        $type = ( 'success' == $_COOKIE['bp-message-type'] ) ? 'updated' : 'error';
     ?>
         <div id="message" class="<?php echo $type; ?>">
-            <p><?php echo $_SESSION['message']; ?></p>
+            <p><?php echo $_COOKIE['bp-message']; ?></p>
         </div>
-    <?php 
-        unset( $_SESSION['message'] );
-        unset( $_SESSION['message_type'] );
-        
+    <?php
         do_action( 'bp_core_render_notice' );
     }