Changeset 14175

Timestamp:

12/26/2025 07:53:17 PM (10 months ago)

Author:

espellcaste

Message:

Restore no-js body class for BuddyPress pages.

Regression introduced at [13672], part of [13418].

Props r-a-y and vapvarun.

See #8679
Fixes #9304 (trunk)

Location:

trunk/src/bp-templates

Files:

• bp-legacy/buddypress-functions.php (modified) (3 diffs)
• bp-nouveau/buddypress-functions.php (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -85 +85 @@
                 add_action( 'bp_enqueue_community_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization
 
-                /** This filter is documented in bp-core/bp-core-dependency.php */
-                if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
-                        // Body no-js class.
-                        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
-                }
+                // Body no-js class.
+                add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
 
                 /** Buttons ***********************************************************/
@@ -477 +474 @@
          * @since 1.7.0
          *
-         * @param array $classes Array of classes to append to body tag.
-         * @return array $classes
+         * @param string[] $classes Array of classes to append to body tag.
+         * @return string[]
          */
         public function add_nojs_body_class( $classes ) {
-                if ( ! in_array( 'no-js', $classes ) )
-                        $classes[] = 'no-js';
+                /** This filter is documented in bp-core/bp-core-dependency.php */
+                if ( ! is_buddypress() || apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+                        return $classes;
+                }
+
+                $classes[] = 'no-js';
 
                 return array_unique( $classes );
@@ -494 +495 @@
          * @since 1.7.0
          */
-        public function localize_scripts() {
-        }
+        public function localize_scripts() {}
 
         /**

trunk/src/bp-templates/bp-nouveau/buddypress-functions.php

@@ -228 +228 @@
                 remove_action( 'bp_enqueue_community_scripts', 'bp_core_confirmation_js' );
 
-                /** This filter is documented in bp-core/bp-core-dependency.php */
-                if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
-                        // Body no-js class.
-                        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
-                }
+                // Body no-js class.
+                add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
 
                 // Ajax querystring.
@@ -484 +481 @@
          * @since 3.0.0
          *
-         * @param array $classes Array of classes to append to body tag.
-         *
-         * @return array $classes
+         * @param string[] $classes Array of classes to append to body tag.
+         * @return string[]
          */
         public function add_nojs_body_class( $classes ) {
+                /** This filter is documented in bp-core/bp-core-dependency.php */
+                if ( ! is_buddypress() || apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+                        return $classes;
+                }
+
                 $classes[] = 'no-js';
+
                 return array_unique( $classes );
         }