Changeset 14149 for trunk/tests/phpunit/testcases/activity/functions/bpActivityGetCommentDepth.php

Timestamp:

12/16/2025 04:24:03 PM (10 months ago)

Author:

espellcaste

Message:

Code Modernization: address the only, so far, two issues related to PHP 8.5.

• Instances of using null as an array offset.
• ArrayIterator::__construct(): Using an object as a backing array for ArrayIterator is deprecated.

Reference: ​https://wiki.php.net/rfc/deprecations_php_8_5\#deprecate_arrayobject_and_arrayiterator_with_objects

Developed in ​https://github.com/buddypress/buddypress/pull/425

Follow-up to [14147].

Props espellcaste.

See #9313 (trunk)

File:

• trunk/tests/phpunit/testcases/activity/functions/bpActivityGetCommentDepth.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/activity/functions/bpActivityGetCommentDepth.php

@@ -41 +41 @@
                 bp_has_activities( 'display_comments=threaded' );
 
-                // Loop through activity comments generated in activity loop.
-                $recursive = new RecursiveIteratorIterator( new RecursiveArrayIterator( $GLOBALS['activities_template']->activities[0]->children ), RecursiveIteratorIterator::SELF_FIRST );
-                foreach ( $recursive as $aid => $a ) {
-                        if ( ! is_numeric( $aid ) || ! is_object( $a ) ) {
+                $children = $GLOBALS['activities_template']->activities[0]->children;
+
+                foreach ( array( $comment_one, $comment_one_one, $comment_two ) as $aid ) {
+                        $a = BP_Activity_Activity::find_comment_in_tree( $children, $aid );
+
+                        if ( false === $a ) {
                                 continue;
                         }
@@ -66 +68 @@
                                         break;
                         }
-
                 }