Changeset 14143

Timestamp:

12/15/2025 02:52:55 AM (9 months ago)

Author:

espellcaste

Message:

The is_home() returns false on BuddyPress pages.

This change addresses an issue where is_home returned true on BuddyPress pages (except if a BuddyPress component was set as the front page).

Props r-a-y.

Closes ​https://github.com/buddypress/buddypress/pull/423/
See #9300 (trunk)

Location:

trunk

Files:

• src/bp-core/classes/class-bp-component.php (modified) (1 diff)
• tests/phpunit/testcases/routing/core.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-component.php

@@ -1265 +1265 @@
         public function parse_query( $query ) {
                 if ( is_buddypress() && 'rewrites' === bp_core_get_query_parser() ) {
+                        // 'is_home' should always be false when on a BP page.
+                        if ( $query->is_main_query() ) {
+                                $query->is_home = false;
+                        }
+
                         add_filter( 'posts_pre_query', array( $this, 'pre_query' ), 10, 2 );
                 }

trunk/tests/phpunit/testcases/routing/core.php

@@ -23 +23 @@
         }
 
-        function test_wordpress_page() {
+        public function test_wordpress_page() {
                 $this->set_permalink_structure( '/%postname%/' );
                 $this->go_to( '/' );
                 $this->assertEmpty( bp_current_component() );
         }
+
+        /**
+         * @ticket BP9300
+         */
+        public function test_buddypress_directory_is_home_false() {
+                $this->set_permalink_structure( '/%postname%/' );
+
+                $is_home_value = null;
+
+                // Capture the is_home value during pre_get_posts for the main query.
+                $callback = function ( $query ) use ( &$is_home_value ) {
+                        if ( $query->is_main_query() ) {
+                                $is_home_value = $query->is_home;
+                        }
+                };
+
+                add_action( 'pre_get_posts', $callback );
+
+                $this->go_to( bp_get_members_directory_permalink() );
+
+                remove_action( 'pre_get_posts', $callback );
+
+                $this->assertFalse( $is_home_value, 'is_home should be false for a BuddyPress directory page on the main query.' );
+        }
 }