Changeset 14071 for trunk/tests/phpunit/testcases/members/test-signup-controller.php

Timestamp:

11/03/2024 06:44:17 PM (23 months ago)

Author:

espellcaste

Message:

Misc changes to the signups and pending accounts.

We are improving how signups and pending accounts are handled in BuddyPress.

• activation emails resend are blocked for one hour, by default;
• emails are checked if they are already in use in a signup;
• signup endpoint (​https://developer.buddypress.org/bp-rest-api/reference/signup/) returns a useful error when feature is disabled;
• Signup::resend: Added the ability to resend to a single ID, instead of an array of IDs.

Props niftythree and imath.

Closes ​https://github.com/buddypress/buddypress/pull/396
See #9229 and #9145
Fixes #9137

File:

• trunk/tests/phpunit/testcases/members/test-signup-controller.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/members/test-signup-controller.php

@@ -210 +210 @@
          * @group create_item
          */
+        public function test_creating_multiple_pending_accounts_with_different_usernames() {
+                $request = new WP_REST_Request( 'POST', $this->endpoint_url );
+
+                $params = $this->set_signup_data( array( 'user_login' => 'user1' ) );
+                $request->set_body_params( $params );
+                $request->set_param( 'context', 'edit' );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+
+                $signup = $response->get_data();
+
+                $this->assertSame( $signup['user_login'], $params['user_login'] );
+                $this->assertSame( $signup['user_email'], $params['user_email'] );
+                $this->assertTrue( ! isset( $signup['activation_key'] ) );
+
+                // Test with the same email.
+                $params = $this->set_signup_data( array( 'user_login' => 'user2' ) );
+                $request->set_body_params( $params );
+                $request->set_param( 'context', 'edit' );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertErrorResponse( 'bp_rest_signup_validation_failed', $response, 500, 'This user\'s email is already registered.' );
+
+                // Test with a different email.
+                $params = $this->set_signup_data( array( 'user_login' => 'user2', 'user_email' => 'user2@example.com' ) );
+                $request->set_body_params( $params );
+                $request->set_param( 'context', 'edit' );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+        }
+
+        /**
+         * @group create_item
+         */
         public function test_create_item_with_signup_fields() {
                 $g1 = $this->bp::factory()->xprofile_group->create();
@@ -664 +700 @@
          * @group resend_item
          */
-        public function test_resend_acivation_email_to_active_signup() {
+        public function test_resend_activation_email_to_active_signup() {
                 $signup_id = $this->create_signup();
                 $signup    = new BP_Signup( $signup_id );
@@ -689 +725 @@
          * @group resend_item
          */
+        public function test_resend_activation_email_to_locked_signup() {
+                $signup_id = $this->create_signup();
+
+                BP_Signup::resend( $signup_id );
+
+                $request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/resend' );
+                $request->set_param( 'id', $signup_id );
+                $request->set_param( 'context', 'edit' );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertEquals( 500, $response->get_status() );
+
+                $error_code = 'bp_rest_signup_resend_activation_email_fail';
+                $error      = $response->as_error();
+                $message    = $error->get_error_message( $error_code );
+
+                $this->assertErrorResponse( $error_code, $response, 500 );
+                $this->assertSame(
+                        $message,
+                        "You've reached the limit for resending your account activation email. Please wait a few minutes and try again. If you continue to experience issues, contact support for assistance."
+                );
+        }
+
+        /**
+         * @group resend_item
+         */
+        public function test_resend_activation_email_to_locked_signup_with_hook() {
+                $signup_id = $this->create_signup();
+
+                BP_Signup::resend( $signup_id );
+
+                add_filter( 'bp_core_signup_resend_activation_lock_time', '__return_zero' );
+
+                $request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/resend' );
+                $request->set_param( 'id', $signup_id );
+                $request->set_param( 'context', 'edit' );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+
+                $all_data = $response->get_data();
+
+                $this->assertTrue( $all_data['sent'] );
+
+                remove_filter( 'bp_core_signup_resend_activation_lock_time', '__return_zero' );
+        }
+
+        /**
+         * @group resend_item
+         */
         public function test_resend_activation_email_invalid_signup_id() {
                 $request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/resend' );
@@ -734 +820 @@
 
         protected function create_signup() {
-                return BP_Signup::add(
+                return $this->bp::factory()->signup->create(
                         array(
                                 'user_login'     => 'user' . wp_rand( 1, 20 ),
@@ -805 +891 @@
                 $this->assertEquals( array( 'view', 'edit' ), $data['endpoints'][0]['args']['context']['enum'] );
         }
+
+        public function test_bp_rest_api_signup_disabled_feature_dispatch_error() {
+                // Disable signups registration.
+                bp_update_option( 'users_can_register', 0 );
+
+                if  ( is_multisite() ) {
+                        update_site_option( 'registration', '' );
+                }
+
+                $request  = new WP_REST_Request( 'OPTIONS', $this->endpoint_url );
+                $response = $this->server->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertEquals( 403, $response->get_status() );
+                $this->assertSame(
+                        $data['message'],
+                        'BuddyPress: The user signup feature is currently disabled. Please activate this feature to proceed.'
+                );
+        }
 }