Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/03/2024 06:19:06 PM (14 months ago)
Author:
espellcaste
Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes ​https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/testcases/members/test-member-cover-controller.php

    r14026 r14070  
    7575     */
    7676    public function test_create_item_with_upload_disabled() {
    77         $this->bp::set_current_user( $this->user );
     77        wp_set_current_user( $this->user );
    7878
    7979        // Disabling cover image upload.
    … …  
    9292     */
    9393    public function test_create_item_empty_image() {
    94         $this->bp::set_current_user( $this->user );
     94        wp_set_current_user( $this->user );
    9595
    9696        $request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', $this->user ) );
    … …  
    116116        $u1 = $this->bp::factory()->user->create();
    117117
    118         $this->bp::set_current_user( $u1 );
     118        wp_set_current_user( $u1 );
    119119
    120120        $request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', $this->user ) );
    … …  
    128128     */
    129129    public function test_create_item_invalid_member_id() {
    130         $this->bp::set_current_user( $this->user );
     130        wp_set_current_user( $this->user );
    131131
    132132        $request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER ) );
    … …  
    166166        $u1 = $this->bp::factory()->user->create();
    167167
    168         $this->bp::set_current_user( $u1 );
     168        wp_set_current_user( $u1 );
    169169
    170170        $request = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', $this->user ) );
    … …  
    178178     */
    179179    public function test_delete_item_invalid_member_id() {
    180         $this->bp::set_current_user( $this->user );
     180        wp_set_current_user( $this->user );
    181181
    182182        $request = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER ) );
    … …  
    190190     */
    191191    public function test_delete_item_failed() {
    192         $this->bp::set_current_user( $this->user );
     192        wp_set_current_user( $this->user );
    193193
    194194        $request = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', $this->user ) );
Note: See TracChangeset for help on using the changeset viewer.