Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/03/2024 06:19:06 PM (22 months ago)
Author:
espellcaste
Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes ​https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/testcases/groups/test-group-cover-controller.php

    r14026 r14070  
    9696                }
    9797
    98                 $this->bp::set_current_user( $this->user );
     98                wp_set_current_user( $this->user );
    9999                $reset_files = $_FILES;
    100100
    … …  
    124124                }
    125125
    126                 $this->bp::set_current_user( $this->user );
     126                wp_set_current_user( $this->user );
    127127                $reset_files = $_FILES;
    128128
    … …  
    151151         */
    152152        public function test_create_item_empty_image() {
    153                 $this->bp::set_current_user( $this->user );
     153                wp_set_current_user( $this->user );
    154154
    155155                $request  = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', $this->group_id ) );
    … …  
    173173                $u1 = $this->bp::factory()->user->create();
    174174
    175                 $this->bp::set_current_user( $u1 );
     175                wp_set_current_user( $u1 );
    176176
    177177                $request  = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', $this->group_id ) );
    … …  
    184184         */
    185185        public function test_create_item_invalid_group_id() {
    186                 $this->bp::set_current_user( $this->user );
     186                wp_set_current_user( $this->user );
    187187
    188188                $request  = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '/%d/cover', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER ) );
    … …  
    220220                $u1 = $this->bp::factory()->user->create();
    221221
    222                 $this->bp::set_current_user( $u1 );
     222                wp_set_current_user( $u1 );
    223223
    224224                $request  = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', $this->group_id ) );
    … …  
    231231         */
    232232        public function test_delete_item_invalid_group_id() {
    233                 $this->bp::set_current_user( $this->user );
     233                wp_set_current_user( $this->user );
    234234
    235235                $request  = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER ) );
    … …  
    242242         */
    243243        public function test_delete_item_failed() {
    244                 $this->bp::set_current_user( $this->user );
     244                wp_set_current_user( $this->user );
    245245
    246246                $request  = new WP_REST_Request( 'DELETE', sprintf( $this->endpoint_url . '/%d/cover', $this->group_id ) );
Note: See TracChangeset for help on using the changeset viewer.