Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/03/2024 06:19:06 PM (5 months ago)
Author:
espellcaste
Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/groups/class-bp-groups-member.php

    r13980 r14070  
    222222        $this->assertTrue( bp_groups_user_can_send_invites( $g, $u_siteadmin ) );
    223223        // Falling back to current user
    224         self::set_current_user( $u_members );
     224        wp_set_current_user( $u_members );
    225225        $this->assertTrue( bp_groups_user_can_send_invites( $g, null ) );
    226226
     
    233233        $this->assertTrue( bp_groups_user_can_send_invites( $g, $u_siteadmin ) );
    234234        // Falling back to current user
    235         self::set_current_user( $u_members );
     235        wp_set_current_user( $u_members );
    236236        $this->assertFalse( bp_groups_user_can_send_invites( $g, null ) );
    237         self::set_current_user( $u_mods );
     237        wp_set_current_user( $u_mods );
    238238        $this->assertTrue( bp_groups_user_can_send_invites( $g, null ) );
    239239
     
    246246        $this->assertTrue( bp_groups_user_can_send_invites( $g, $u_siteadmin ) );
    247247        // Falling back to current user
    248         self::set_current_user( $u_mods );
     248        wp_set_current_user( $u_mods );
    249249        $this->assertFalse( bp_groups_user_can_send_invites( $g, null ) );
    250         self::set_current_user( $u_admins );
     250        wp_set_current_user( $u_admins );
    251251        $this->assertTrue( bp_groups_user_can_send_invites( $g, null ) );
    252252
     
    264264        $this->assertTrue( bp_groups_user_can_send_invites( null, $u_mods ) );
    265265
    266         self::set_current_user( $old_current_user );
     266        wp_set_current_user( $old_current_user );
    267267    }
    268268
     
    680680        $g = self::factory()->group->create();
    681681        $old_current_user = get_current_user_id();
    682         self::set_current_user( $u1 );
     682        wp_set_current_user( $u1 );
    683683
    684684        groups_join_group( $g );
    685685        $membership_id = groups_is_user_member( $u1, $g );
    686686        $this->assertTrue( is_numeric( $membership_id ) && $membership_id > 0 );
    687         self::set_current_user( $old_current_user );
     687        wp_set_current_user( $old_current_user );
    688688    }
    689689
     
    754754
    755755        $before = groups_get_total_member_count( $g );
    756         self::set_current_user( $u2 );
     756        wp_set_current_user( $u2 );
    757757        groups_leave_group( $g, $u2 );
    758758        $after = groups_get_total_member_count( $g );
    759759
    760760        $this->assertEquals( $before - 1, $after );
    761         self::set_current_user( $old_current_user );
     761        wp_set_current_user( $old_current_user );
    762762    }
    763763
     
    774774
    775775        $before = groups_get_total_member_count( $g );
    776         self::set_current_user( $u2 );
     776        wp_set_current_user( $u2 );
    777777        groups_leave_group( $g );
    778778        $after = groups_get_total_member_count( $g );
    779779
    780780        $this->assertEquals( $before - 1, $after );
    781         self::set_current_user( $old_current_user );
     781        wp_set_current_user( $old_current_user );
    782782    }
    783783
     
    794794
    795795        $before = groups_get_total_member_count( $g );
    796         self::set_current_user( $u1 );
     796        wp_set_current_user( $u1 );
    797797        groups_leave_group( $g, $u2 );
    798798        $after = groups_get_total_member_count( $g );
    799799
    800800        $this->assertEquals( $before - 1, $after );
    801         self::set_current_user( $old_current_user );
     801        wp_set_current_user( $old_current_user );
    802802    }
    803803
     
    816816
    817817        $before = groups_get_total_member_count( $g );
    818         self::set_current_user( $u1 );
     818        wp_set_current_user( $u1 );
    819819        groups_leave_group( $g, $u2 );
    820820        $after = groups_get_total_member_count( $g );
    821821
    822822        $this->assertEquals( $before - 1, $after );
    823         self::set_current_user( $old_current_user );
     823        wp_set_current_user( $old_current_user );
    824824    }
    825825
     
    836836
    837837        $before = groups_get_total_member_count( $g );
    838         self::set_current_user( $u1 );
     838        wp_set_current_user( $u1 );
    839839        groups_leave_group( $g, $u1 );
    840840        $after = groups_get_total_member_count( $g );
    841841
    842842        $this->assertEquals( $before, $after );
    843         self::set_current_user( $old_current_user );
     843        wp_set_current_user( $old_current_user );
    844844    }
    845845
     
    858858
    859859        $before = groups_get_total_member_count( $g );
    860         self::set_current_user( $u1 );
     860        wp_set_current_user( $u1 );
    861861        groups_leave_group( $g, $u1 );
    862862        $after = groups_get_total_member_count( $g );
    863863
    864864        $this->assertEquals( $before - 1, $after );
    865         self::set_current_user( $old_current_user );
     865        wp_set_current_user( $old_current_user );
    866866    }
    867867
     
    935935        ) );
    936936
    937         self::set_current_user( $u2 );
     937        wp_set_current_user( $u2 );
    938938        $groups = groups_get_invites_for_user();
    939939        $this->assertEqualSets( array( $g1, $g2, $g3 ), wp_list_pluck( $groups['groups'], 'id' ) );
    940940
    941         self::set_current_user( $old_current_user );
     941        wp_set_current_user( $old_current_user );
    942942    }
    943943
Note: See TracChangeset for help on using the changeset viewer.