Changeset 14070 for trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

Timestamp:

11/03/2024 06:19:06 PM (13 months ago)

Author:

espellcaste

Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes ​https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:

• trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (11 diffs)

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -976 +976 @@
 
         // Instantiate group object.
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
         $group = new BP_Groups_Group( $g );
 
@@ -982 +982 @@
         $this->assertTrue( ! empty( $group->is_member ) );
 
-        self::set_current_user( $this->old_current_user );
+        wp_set_current_user( $this->old_current_user );
     }
 
@@ -1470 +1470 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( 0 );
+        wp_set_current_user( 0 );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1501 +1501 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1533 +1533 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1573 +1573 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1610 +1610 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1648 +1648 @@
 
         $old_user = get_current_user_id();
-        self::set_current_user( $u );
+        wp_set_current_user( $u );
 
         $this->assertEquals( $expected, BP_Groups_Group::get_group_extras( $paged_groups, $group_ids ) );
 
-        self::set_current_user( $old_user );
+        wp_set_current_user( $old_user );
     }
 
@@ -1745 +1745 @@
     /**
      * @ticket BP5451
+     * @ticket BP7658
      */
     public function test_is_member_property() {
-        $users = self::factory()->user->create_many( 2 );
-
-        $g = self::factory()->group->create( array(
-            'creator_id' => $users[0],
-        ) );
-
-        wp_set_current_user( $users[1] );
+        $u1 = self::factory()->user->create();
+        $u2 = self::factory()->user->create();
+        $g  = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+        wp_set_current_user( $u2 );
 
         $group_a = new BP_Groups_Group( $g );
+
+        // $u2 IS NOT a member of $g yet.
         $this->assertFalse( $group_a->is_member );
 
-        $this->add_user_to_group( $users[1], $g );
+        // Now $u2 IS a member of $g.
+        $this->add_user_to_group( $u2, $g );
+
         $group_b = new BP_Groups_Group( $g );
-        $this->assertFalse( $group_b->is_member );
+
+        // $u2 IS a member of $g. This returns the ID of the membership, not the User id or boolean.
+        $this->assertTrue( (bool) $group_b->is_member );
     }
 
     /**
      * @ticket BP5451
+     * @ticket BP7658
      */
     public function test_is_invited_property() {
-        $users = self::factory()->user->create_many( 2 );
-
-        $g = self::factory()->group->create( array(
-            'creator_id' => $users[0],
-        ) );
-
-        wp_set_current_user( $users[1] );
+        $u1 = self::factory()->user->create();
+        $u2 = self::factory()->user->create();
+        $g  = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+        wp_set_current_user( $u2 );
 
         $group_a = new BP_Groups_Group( $g );
+
         $this->assertFalse( $group_a->is_invited );
 
         groups_invite_user( array(
-            'user_id'    => $users[1],
+            'user_id'    => $u2,
             'group_id'   => $g,
-            'inviter_id' => $users[0],
+            'inviter_id' => $u1,
             'send_invite' => 1
         ) );
 
         $group_b = new BP_Groups_Group( $g );
-        $this->assertFalse( $group_b->is_invited );
+
+        $this->assertTrue( wp_validate_boolean( $group_b->is_invited ) );
     }
 
@@ -1793 +1799 @@
      */
     public function test_is_pending_property() {
-        $users = self::factory()->user->create_many( 2 );
-
-        $g = self::factory()->group->create( array(
-            'creator_id' => $users[0],
-        ) );
-
-        wp_set_current_user( $users[1] );
+        $u1 = self::factory()->user->create();
+        $u2 = self::factory()->user->create();
+        $g  = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+        wp_set_current_user( $u2 );
 
         $group_a = new BP_Groups_Group( $g );
+
         $this->assertFalse( $group_a->is_pending );
 
         groups_send_membership_request( array(
-            'user_id' => $users[1],
+            'user_id' => $u2,
             'group_id' => $g
         ) );
@@ -1812 +1817 @@
         $this->assertFalse( $group_b->is_pending );
     }
-
 
     /**