Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/03/2024 06:19:06 PM (5 months ago)
Author:
espellcaste
Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/friends/functions.php

    r13980 r14070  
    6767        // accept friendship
    6868        $old_user = get_current_user_id();
    69         self::set_current_user( $u1 );
     69        wp_set_current_user( $u1 );
    7070        friends_accept_friendship( friends_get_friendship_id( $u2, $u1 ) );
    7171
     
    7474        $this->assertEquals( array( $u3 ), $requests );
    7575
    76         self::set_current_user( $old_user );
     76        wp_set_current_user( $old_user );
    7777    }
    7878
     
    124124        // user 2 withdraws friendship
    125125        $old_user = get_current_user_id();
    126         self::set_current_user( $u2 );
     126        wp_set_current_user( $u2 );
    127127        friends_withdraw_friendship( $u2, $u1 );
    128128
     
    131131        $this->assertEquals( array(), $requests );
    132132
    133         self::set_current_user( $old_user );
     133        wp_set_current_user( $old_user );
    134134    }
    135135
     
    152152        // user 1 rejects friendship
    153153        $old_user = get_current_user_id();
    154         self::set_current_user( $u1 );
     154        wp_set_current_user( $u1 );
    155155        friends_reject_friendship( friends_get_friendship_id( $u2, $u1 ) );
    156156
     
    159159        $this->assertEquals( array(), $requests );
    160160
    161         self::set_current_user( $old_user );
     161        wp_set_current_user( $old_user );
    162162    }
    163163
     
    198198
    199199        $old_user = get_current_user_id();
    200         self::set_current_user( $u1 );
     200        wp_set_current_user( $u1 );
    201201
    202202        $found = array();
     
    217217        // clean up
    218218        $GLOBALS['members_template'] = null;
    219         self::set_current_user( $old_user );
     219        wp_set_current_user( $old_user );
    220220    }
    221221
     
    300300         * @see bp_friends_filter_user_query_populate_extras()
    301301         */
    302         self::set_current_user( $u1 );
     302        wp_set_current_user( $u1 );
    303303        $this->go_to( bp_get_members_directory_permalink() );
    304304        ob_start();
     
    315315         * properly.
    316316         */
    317         self::set_current_user( $u2 );
     317        wp_set_current_user( $u2 );
    318318        friends_accept_friendship( friends_get_friendship_id( $u1, $u2 ) );
    319319
    320320        // Afterwards, user 1 decides to cancel friendship.
    321         self::set_current_user( $u1 );
     321        wp_set_current_user( $u1 );
    322322        friends_remove_friend( $u1, $u2 );
    323323
     
    325325        $this->assertEquals( 'not_friends', BP_Friends_Friendship::check_is_friend( $u1, $u2 ) );
    326326
    327         self::set_current_user( $old_user );
     327        wp_set_current_user( $old_user );
    328328    }
    329329
Note: See TracChangeset for help on using the changeset viewer.