Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/03/2024 06:19:06 PM (5 months ago)
Author:
espellcaste
Message:

A user is no longer de-authenticated when making REST API requests.

We are introducing a new BP_LoggedIn_User class to fetch data about a BuddyPress logged-in user. This new addition fixes an issue where a user could be de-authenticated when making REST API requests.

Props dcavins, DJPaul, johnjamesjacoby, and imath.

Closes https://github.com/buddypress/buddypress/pull/395
See #9229 and #9145
Fixes #7658

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/activity/template.php

    r14026 r14070  
    1212        $u             = self::factory()->user->create();
    1313        $original_user = bp_loggedin_user_id();
    14         self::set_current_user( $u );
     14        wp_set_current_user( $u );
    1515
    1616        $a = self::factory()->activity->create(
     
    2626
    2727        // Logged-out user can't delete
    28         self::set_current_user( 0 );
     28        wp_set_current_user( 0 );
    2929        $this->assertFalse( bp_activity_user_can_delete( $activity ) );
    3030
    3131        // Miscellaneous user can't delete
    3232        $misc_user = self::factory()->user->create();
    33         self::set_current_user( $misc_user );
     33        wp_set_current_user( $misc_user );
    3434        $this->assertFalse( bp_activity_user_can_delete( $activity ) );
    3535
     
    4545        $bp->is_single_item = $is_single_item;
    4646        $bp->is_item_admin  = $is_item_admin;
    47         self::set_current_user( $original_user );
     47        wp_set_current_user( $original_user );
    4848    }
    4949
     
    5555        $old_user = get_current_user_id();
    5656        $u        = self::factory()->user->create();
    57         self::set_current_user( $u );
     57        wp_set_current_user( $u );
    5858
    5959        // create an activity update for the user
     
    7575
    7676        // reset
    77         self::set_current_user( $old_user );
     77        wp_set_current_user( $old_user );
    7878    }
    7979
     
    105105
    106106        $current_user = bp_loggedin_user_id();
    107         self::set_current_user( $user_id );
     107        wp_set_current_user( $user_id );
    108108
    109109        bp_activity_add_user_favorite( $a1, $user_id );
    110110        bp_activity_add_user_favorite( $a2, $user_id );
    111111
    112         self::set_current_user( $current_user );
     112        wp_set_current_user( $current_user );
    113113
    114114        // groan. It sucks that you have to invoke the global
     
    159159        // save the current user and override logged-in user
    160160        $old_user = get_current_user_id();
    161         self::set_current_user( $u1 );
     161        wp_set_current_user( $u1 );
    162162
    163163        $now = time();
     
    209209        // clean up!
    210210        $activities_template = null;
    211         self::set_current_user( $old_user );
     211        wp_set_current_user( $old_user );
    212212    }
    213213
     
    11521152        $u3 = self::factory()->user->create();
    11531153
    1154         self::set_current_user( $u1 );
     1154        wp_set_current_user( $u1 );
    11551155
    11561156        $g = self::factory()->group->create(
     
    12121212        $u3 = self::factory()->user->create();
    12131213
    1214         self::set_current_user( $u1 );
     1214        wp_set_current_user( $u1 );
    12151215
    12161216        $g = self::factory()->group->create(
Note: See TracChangeset for help on using the changeset viewer.