Changeset 14068 for trunk/src/bp-xprofile/bp-xprofile-functions.php

Timestamp:

11/01/2024 06:07:04 AM (13 months ago)

Author:

imath

Message:

Improve BuddyPress compatibility with WP Playground previews

• Avoid using SIGNED casting into the SQL query retrieving the signup field IDs as it's generating an error with WP Playground SQLite db.
• Make sure BP URI globals are set during Ajax requests passing the current displayed page canonical URL into these requests.
• Ignore the bp-message cookie when its value is set to deleted to prevent the wrong display of a template notice when BP Legacy is the active template pack.
• Update JSON blueprints to latest WP Playground's blueprint schema.

Props espellcaste

Fixes #9207
Closes ​https://github.com/buddypress/buddypress/pull/389

File:

• trunk/src/bp-xprofile/bp-xprofile-functions.php (modified) (2 diffs)

trunk/src/bp-xprofile/bp-xprofile-functions.php

@@ -1478 +1478 @@
  *
  * @since 8.0.0
+ * @since 15.0.0 The SQL request was adapted to support WP Playground's SQLite DB.
  *
  * @global wpdb $wpdb WordPress database object.
@@ -1490 +1491 @@
         $bp = buddypress();
 
-        $signup_field_ids = $wpdb->get_col( "SELECT object_id FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND meta_key = 'signup_position' ORDER BY CONVERT(meta_value, SIGNED) ASC" );
+        // WP Playground's SQLite DB does not support CONVERT AS SIGNED.
+        $results          = $wpdb->get_results( "SELECT object_id, meta_value FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND meta_key = 'signup_position'" );
+        $signup_field_ids = array();
+
+        foreach ( $results as $result ) {
+            $index                      = (int) $result->meta_value;
+            $signup_field_ids[ $index ] = (int) $result->object_id;
+        }
+
+        // Sort.
+        ksort( $signup_field_ids );
 
         wp_cache_set( 'signup_fields', $signup_field_ids, 'bp_xprofile' );
     }
 
-    return array_map( 'intval', $signup_field_ids );
+    return array_values( $signup_field_ids );
 }