Changeset 14026 for trunk/tests/phpunit/testcases/core/class-bp-component.php

Timestamp:

09/27/2024 09:11:27 PM (15 months ago)

Author:

espellcaste

Message:

Include the V2 of the BP REST API in BuddyPress core.

We are officially deprecating the V1 of the BP REST API. And bundling the new, default, V2 of the BP REST API inside BuddyPress core. Previously, the V1 was developed as a plugin in a separate repo (​https://github.com/buddypress/BP-REST).

• One of the main differences between the V1 and V2 is how objects are returned. Single items are no longer returned as an array;
• We have a new BP_Test_REST_Controller_Testcase for testing the new API endpoints;
• We changed the names of our controllers to follow our autoloader rules;
• Removed the BP-REST plugin from wp-env and from our release script;
• And we added notices for the deprecated V1 API (endpoints and files).

Props imath & I. ;)

Fixes #8200
See #9145
Closes ​https://github.com/buddypress/buddypress/pull/337

File:

• trunk/tests/phpunit/testcases/core/class-bp-component.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/class-bp-component.php

@@ -1 +1 @@
 <?php
 
-include_once BP_TESTS_DIR . '/assets/bp-rest-api-controllers.php';
 include_once BP_TESTS_DIR . '/assets/class-bptest-component.php';
 
@@ -9 +8 @@
  */
 class BP_Tests_BP_Component_TestCases extends BP_UnitTestCase {
-    public function set_up() {
-        parent::set_up();
-
-        $bp = buddypress();
-        $bp->unit_test_rest = new stdClass;
-        $bp->unit_test_rest->controllers = array();
-    }
-
-    public function remove_controller( $controllers ) {
-        return array_diff( $controllers, array( 'BP_REST_Members_Endpoint' ) );
-    }
-
-    public function add_controller( $controllers ) {
-        return array_merge( $controllers, array( 'Foo_Bar' ) );
-    }
-
-    public function test_rest_api_init_for_members_component() {
-        $bp_members = new BP_Members_Component();
-        $bp         = buddypress();
-
-        $bp_members->rest_api_init();
-
-        $this->assertSame( $bp->unit_test_rest->controllers, array(
-            'BP_REST_Members_Endpoint',
-            'BP_REST_Attachments_Member_Avatar_Endpoint',
-            'BP_REST_Attachments_Member_Cover_Endpoint',
-        ) );
-    }
-
-    public function test_rest_api_init_for_members_component_can_remove_controller() {
-        $bp_members = new BP_Members_Component();
-        $bp         = buddypress();
-
-        add_filter( 'bp_members_rest_api_controllers', array( $this, 'remove_controller' ) );
-
-        $bp_members->rest_api_init();
-
-        remove_filter( 'bp_members_rest_api_controllers', array( $this, 'remove_controller' ) );
-
-        $this->assertSame( $bp->unit_test_rest->controllers, array(
-            'BP_REST_Attachments_Member_Avatar_Endpoint',
-            'BP_REST_Attachments_Member_Cover_Endpoint',
-        ) );
-    }
-
-    public function test_rest_api_init_for_members_component_cannot_add_controller() {
-        $bp_members = new BP_Members_Component();
-        $bp         = buddypress();
-
-        add_filter( 'bp_members_rest_api_controllers', array( $this, 'add_controller' ) );
-
-        $bp_members->rest_api_init();
-
-        remove_filter( 'bp_members_rest_api_controllers', array( $this, 'add_controller' ) );
-
-        $this->assertSame( $bp->unit_test_rest->controllers, array(
-            'BP_REST_Members_Endpoint',
-            'BP_REST_Attachments_Member_Avatar_Endpoint',
-            'BP_REST_Attachments_Member_Cover_Endpoint',
-        ) );
-    }
 
     /**