Changeset 14024 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

09/20/2024 06:27:29 PM (23 months ago)

Author:

imath

Message:

Groups Admin: improve feedback messages after group edits

In particular use more meaningful confirmation/error messages when a group member is promoted, demoted, banned, removed or when a user is added to the group.

Props martenw

Fixes #9223
Closes ​https://github.com/buddypress/buddypress/pull/374

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (6 diffs)

trunk/src/bp-groups/bp-groups-functions.php

@@ -424 +424 @@
 function groups_edit_group_settings( $group_id, $enable_forum, $status, $invite_status = false, $parent_id = false ) {
 
-        $group = groups_get_group( $group_id );
+        $group               = groups_get_group( $group_id );
         $group->enable_forum = $enable_forum;
 
@@ -431 +431 @@
          * from private and there are outstanding membership requests, auto-accept those requests.
          */
-        if ( 'private' == $group->status && 'public' == $status )
+        if ( 'private' === $group->status && 'public' === $status ) {
                 groups_accept_all_pending_membership_requests( $group->id );
+        }
 
         // Now update the status.
@@ -442 +443 @@
         }
 
-        if ( !$group->save() )
+        if ( ! $group->save() ) {
                 return false;
+        }
 
         // Set the invite status.
-        if ( $invite_status )
+        if ( $invite_status ) {
                 groups_update_groupmeta( $group->id, 'invite_status', $invite_status );
+        }
 
         groups_update_groupmeta( $group->id, 'last_activity', bp_core_current_time() );
@@ -1359 +1362 @@
                         'id'           => 'admin',
                         'name'         => __( 'Administrator', 'buddypress' ),
+                        'plural_name'  => _x( 'administrators', 'group role plural name', 'buddypress' ),
                         'is_admin'     => true,
                         'is_banned'    => false,
@@ -1367 +1371 @@
                         'id'           => 'mod',
                         'name'         => __( 'Moderator', 'buddypress' ),
+                        'plural_name'  => _x( 'moderators', 'group role plural name', 'buddypress' ),
                         'is_admin'     => false,
                         'is_banned'    => false,
@@ -1375 +1380 @@
                         'id'           => 'member',
                         'name'         => __( 'Member', 'buddypress' ),
+                        'plural_name'  => _x( 'members', 'group role plural name', 'buddypress' ),
                         'is_admin'     => false,
                         'is_banned'    => false,