Changeset 13998 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

08/07/2024 02:08:06 PM (9 months ago)

Author:

imath

Message:

Make sure 12.0 deprecated code is loaded until version 15.0

Version 12.0 changed BuddyPress a lot with the introduction of the BP Rewrites API. To give more time to advanced users, BP plugin or theme developers so that they make their code ready for this API, unlike how we deal with deprecated code since r13304 & for the 2 following major releases (14.0 & 15.0), we will carry on loading it to prevent potential errors.

Props emaralive, espellcaste.

See #9210 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/352

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (1 diff)

trunk/src/bp-core/bp-core-functions.php

@@ -5013 +5013 @@
         }
 
-        // Only load 12.0 deprecated functions.
-        return array( 12.0 );
-    }
-
-    $index_first_major = array_search( $initial_version, $deprecated_functions_versions, true );
-    if ( false === $index_first_major ) {
-        return array_splice( $deprecated_functions_versions, -2 );
-    }
-
-    $latest_deprecated_functions_versions = array_splice( $deprecated_functions_versions, $index_first_major );
-
-    if ( 2 <= count( $latest_deprecated_functions_versions ) ) {
-        $latest_deprecated_functions_versions = array_splice( $latest_deprecated_functions_versions, -2 );
-    }
-
-    $index_initial_version = array_search( $initial_version, $latest_deprecated_functions_versions, true );
-    if ( false !== $index_initial_version && 12.0 !== $initial_version ) {
-        unset( $latest_deprecated_functions_versions[ $index_initial_version ] );
-    }
-
-    return $latest_deprecated_functions_versions;
+        // Load 12.0 deprecated functions only when BP was installed with 12.0, 14.0 or 15.0.
+        if ( in_array( $initial_version, array( 12.0, 14.0, 15.0 ), true ) ) {
+            return array( 12.0 );
+        }
+
+        return array();
+    }
+
+    $keep_last = 2;
+    if ( (float) 15 >= $initial_version ) {
+        $keep_last = count( $deprecated_functions_versions ) - array_search( 12.0, $deprecated_functions_versions, true );
+    }
+
+    return array_splice( $deprecated_functions_versions, -$keep_last );
 }