Changeset 13989 for trunk/tests/phpunit/testcases/members/class-bp-signup.php

Timestamp:

07/27/2024 08:12:32 PM (12 months ago)

Author:

espellcaste

Message:

Members: Add cache_results flag to the BP_Signup::get getter.

When performing a request with cache_results, it stops the signup information retrieved from being added to the cache.

See #8552
Closes ​https://github.com/buddypress/buddypress/pull/345/

File:

• trunk/tests/phpunit/testcases/members/class-bp-signup.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/members/class-bp-signup.php

@@ -359 +359 @@
 
     /**
+     * @ticket BP8552
+     * @group cache
+     */
+    public function test_signup_query_with_ids_cache_results() {
+        global $wpdb;
+
+        self::factory()->signup->create_many( 2 );
+
+        // Reset.
+        $wpdb->num_queries = 0;
+
+        $first_query = BP_Signup::get(
+            array(
+                'cache_results' => true,
+                'fields'        => 'ids',
+            )
+        );
+
+        $queries_before = get_num_queries();
+
+        $second_query = BP_Signup::get(
+            array(
+                'cache_results' => false,
+                'fields'        => 'ids',
+            )
+        );
+
+        $queries_after = get_num_queries();
+
+        $this->assertNotSame( $queries_before, $queries_after, 'Assert that queries are run' );
+        $this->assertSame( 4, $queries_after, 'Assert that the uncached query was run' );
+        $this->assertSameSets( $first_query['signups'], $second_query['signups'], 'Results of the query are expected to match.' );
+        $this->assertSame( $first_query['total'], $second_query['total'], 'Results of the query are expected to match.' );
+    }
+
+    /**
+     * @ticket BP8552
+     * @group cache
+     */
+    public function test_signup_query_with_all_cache_results() {
+        global $wpdb;
+
+        self::factory()->signup->create_many( 2 );
+
+        // Reset.
+        $wpdb->num_queries = 0;
+
+        $first_query = BP_Signup::get(
+            array( 'cache_results' => true )
+        );
+
+        $queries_before = get_num_queries();
+
+        $second_query = BP_Signup::get(
+            array( 'cache_results' => false )
+        );
+
+        $queries_after = get_num_queries();
+
+        $this->assertNotSame( $queries_before, $queries_after, 'Assert that queries are run' );
+        $this->assertSame( 5, $queries_after, 'Assert that the uncached query was run' );
+        $this->assertSame( $first_query['total'], $second_query['total'], 'Results of the query are expected to match.' );
+    }
+
+    /**
      * @group cache
      */
@@ -364 +429 @@
         global $wpdb;
 
-        $s = self::factory()->signup->create();
-
-        $found1 = BP_Signup::get(
-            array(
-                'fields' => 'ids',
-            )
-        );
-
-        $num_queries = $wpdb->num_queries;
-
-        $found2 = BP_Signup::get(
-            array(
-                'fields' => 'ids',
-            )
-        );
-
-        $this->assertEqualSets( $found1, $found2 );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        self::factory()->signup->create_many( 2 );
+
+        // Reset.
+        $wpdb->num_queries = 0;
+
+        $args = array( 'fields' => 'ids' );
+
+        $first_query = BP_Signup::get( $args );
+
+        $queries_before = get_num_queries();
+
+        $second_query = BP_Signup::get( $args );
+
+        $queries_after = get_num_queries();
+
+        $this->assertSame( $queries_before, $queries_after, 'Assert that queries are run' );
+        $this->assertSame( 2, $queries_after, 'Assert that the uncached query was run' );
+        $this->assertSameSets( $first_query['signups'], $second_query['signups'], 'Results of the query are expected to match.' );
     }
 
@@ -388 +453 @@
      */
     public function test_get_query_caches_should_be_busted_by_add() {
-        $s1 = self::factory()->signup->create();
-
-        $found1 = BP_Signup::get(
-            array(
-                'fields' => 'ids',
-            )
-        );
+        $s1   = self::factory()->signup->create();
+        $args = array( 'fields' => 'ids' );
+
+        $found1 = BP_Signup::get( $args );
         $this->assertEqualSets( array( $s1 ), $found1['signups'] );
 
         $s2 = self::factory()->signup->create();
-        $found2 = BP_Signup::get(
-            array(
-                'fields' => 'ids',
-            )
-        );
+        $found2 = BP_Signup::get( $args );
         $this->assertEqualSets( array( $s2 ), $found2['signups'] );
     }
@@ -521 +579 @@
         $this->assertEqualSets( array( $s1, $s2 ), $found1['signups'] );
 
-        $activate = BP_Signup::activate( (array) $s2 );
+        BP_Signup::activate( (array) $s2 );
 
         $found2 = BP_Signup::get(
@@ -570 +628 @@
         $this->assertFalse( $found1->active );
 
-        $activate = BP_Signup::activate( (array) $s1 );
+        BP_Signup::activate( (array) $s1 );
 
         $found2 = new BP_Signup( $s1 );