Changeset 13986 for trunk/src/bp-messages/bp-messages-functions.php

Timestamp:

07/27/2024 07:16:17 PM (2 years ago)

Author:

espellcaste

Message:

Allow creating messages with non-empty content.

Use of the PHP empty function to check if the message content is empty is not ideal when creating a message. Update the logic to consider any string as non-empty.

Props emaralive, niftythree.

See #9175
Closes ​https://github.com/buddypress/buddypress/pull/330

File:

• trunk/src/bp-messages/bp-messages-functions.php (modified) (2 diffs)

trunk/src/bp-messages/bp-messages-functions.php

@@ -57 +57 @@
         );
 
+        // Check if the message content is empty.
+        $content       = $r['content'];
+        $empty_content = false;
+
+        // Any string is considered non-empty.
+        if ( ! is_string( $content ) || '' === $content ) {
+                $empty_content = true;
+        }
+
         // Bail if no sender or no content.
-        if ( empty( $r['sender_id'] ) || empty( $r['content'] ) ) {
+        if ( empty( $r['sender_id'] ) || $empty_content ) {
                 if ( 'wp_error' === $r['error_type'] ) {
                         if ( empty( $r['sender_id'] ) ) {
@@ -69 +78 @@
 
                         return new WP_Error( $error_code, $feedback );
-
-                } else {
-                        return false;
-                }
+                }
+
+                return false;
         }