Changeset 13983 for trunk/src/bp-core/admin/bp-core-admin-types.php

Timestamp:

07/27/2024 06:44:41 PM (12 months ago)

Author:

espellcaste

Message:

Require singular and plural names for BuddyPress custom types.

When creating a member or group type, require that both singular and plural names are provided. This ensures that the type can be properly registered and used throughout BuddyPress.

Props 1naveengiri, imath, imranmd.

Fixes #9092
Closes ​https://github.com/buddypress/buddypress/pull/335/

File:

• trunk/src/bp-core/admin/bp-core-admin-types.php (modified) (4 diffs)

trunk/src/bp-core/admin/bp-core-admin-types.php

@@ -45 +45 @@
  *     @type string $taxonomy   The Type's taxonomy. Required.
  *     @type string $bp_type_id Unique string identifier for the member type. Required.
+ *     @type string $bp_type_singular_name Singular name for the member type. Required.
+ *     @type string $bp_type_name Plural name for the member type. Required.
  *     @see keys of the array returned by bp_get_type_metadata_schema() for the other arguments.
  * }
- * @return integer|WP_Error The Type's term ID on success. A WP_Error object otherwise.
+ * @return int|WP_Error The Type's term ID on success. A WP_Error object otherwise.
  */
 function bp_core_admin_insert_type( $args = array() ) {
@@ -53 +55 @@
         'taxonomy'   => '',
         'bp_type_id' => '',
+        'bp_type_singular_name' => '',
+        'bp_type_name' => '',
     );
 
@@ -67 +71 @@
             __( 'The Type ID value is missing', 'buddypress' ),
             array( 'message' => 1 )
+        );
+    }
+
+    if ( ! $args['bp_type_singular_name'] ) {
+        return new WP_Error(
+            'empty_field_singular',
+            __( 'The Singular Name value is missing', 'buddypress' ),
+            array(
+                'message' => 11,
+            )
+        );
+    }
+
+    if ( ! $args['bp_type_name'] ) {
+        return new WP_Error(
+            'empty_field_plural',
+            __( 'The Plural Name value is missing', 'buddypress' ),
+            array(
+                'message' => 12,
+            )
         );
     }
@@ -117 +141 @@
     }
 
+    $type_term_id = reset( $type_term_id );
+
     /**
      * Hook here to add code once the type has been inserted.