Changeset 13980 for trunk/tests/phpunit/testcases/messages/notifications.php

Timestamp:

07/27/2024 04:30:23 PM (2 years ago)

Author:

espellcaste

Message:

Unit Tests: Conducted a thorough review of existing unit tests files and improved them to ensure robustness.

Props imath.

Closes ​https://github.com/buddypress/buddypress/pull/295
Fixes #9081

File:

• trunk/tests/phpunit/testcases/messages/notifications.php (modified) (7 diffs)

trunk/tests/phpunit/testcases/messages/notifications.php

@@ -8 +8 @@
 class BP_Tests_Messages_Notifications extends BP_UnitTestCase {
 
+        protected $reset_user_id = 0;
         protected $filter_fired;
 
@@ -14 +15 @@
 
                 $this->reset_user_id = get_current_user_id();
-
                 $this->filter_fired = '';
         }
 
         public function tear_down() {
+                self::set_current_user( $this->reset_user_id );
+
                 parent::tear_down();
-
-                $this->set_current_user( $this->reset_user_id );
         }
 
@@ -31 +31 @@
                 $t = 12;
                 $u = self::factory()->user->create();
-                $this->set_current_user( $u );
+                self::set_current_user( $u );
 
                 // Admin
@@ -55 +55 @@
                 $t = 12;
                 $u = self::factory()->user->create();
-                $this->set_current_user( $u );
+                self::set_current_user( $u );
 
                 // Admin
@@ -79 +79 @@
                 $t = 12;
                 $u = self::factory()->user->create();
-                $this->set_current_user( $u );
+                self::set_current_user( $u );
 
                 // Admin
@@ -103 +103 @@
                 $t = 12;
                 $u = self::factory()->user->create();
-                $this->set_current_user( $u );
+                self::set_current_user( $u );
 
                 // Admin
@@ -189 +189 @@
                 );
 
-                $this->set_current_user( $u1 );
+                self::set_current_user( $u1 );
 
                 // Mark a thread read.