Changeset 13980 for trunk/tests/phpunit/testcases/core/caps.php

Timestamp:

07/27/2024 04:30:23 PM (6 months ago)

Author:

espellcaste

Message:

Unit Tests: Conducted a thorough review of existing unit tests files and improved them to ensure robustness.

Props imath.

Closes ​https://github.com/buddypress/buddypress/pull/295
Fixes #9081

File:

• trunk/tests/phpunit/testcases/core/caps.php (modified) (9 diffs)

trunk/tests/phpunit/testcases/core/caps.php

@@ -20 +20 @@
 
     public function tear_down() {
+        self::set_current_user( $this->reset_user_id );
         parent::tear_down();
-
-        $this->set_current_user( $this->reset_user_id );
     }
 
@@ -33 +32 @@
         $u = self::factory()->user->create();
 
-        $this->set_current_user( $u );
+        self::set_current_user( $u );
 
         add_filter( 'user_has_cap', array( $this, 'grant_cap_foo' ), 10, 2 );
@@ -55 +54 @@
         $u = self::factory()->user->create();
 
-        $this->set_current_user( $u );
+        self::set_current_user( $u );
 
         add_filter( 'user_has_cap', array( $this, 'grant_cap_foo' ), 10, 2 );
@@ -89 +88 @@
         );
 
-        $this->set_current_user( $u );
+        self::set_current_user( $u );
 
         $this->assertTrue( bp_current_user_can( 'bp_moderate' ), 'Administrator can `bp_moderate` on default WordPress config' );
@@ -109 +108 @@
         );
 
-        $this->set_current_user( $u );
+        self::set_current_user( $u );
 
         $this->assertTrue( bp_current_user_can( 'bp_moderate' ), 'Users having a `manage_options` cap into their role can `bp_moderate`' );
@@ -131 +130 @@
         );
 
-        $this->set_current_user( $u1 );
+        self::set_current_user( $u1 );
 
         $email = self::factory()->post->create(
@@ -141 +140 @@
         $this->assertTrue( current_user_can( 'edit_post', $email ), 'Administrator should be able to edit emails they created' );
 
-        $this->set_current_user( $u2 );
+        self::set_current_user( $u2 );
 
         $this->assertTrue( current_user_can( 'edit_post', $email ), 'Administrator should be able to edit emails others created when BuddyPress is not network activated' );
@@ -172 +171 @@
         switch_to_blog( $this->blog_id );
 
-        $this->set_current_user( $u1 );
+        self::set_current_user( $u1 );
         $this->assertTrue( bp_current_user_can( 'bp_moderate' ), 'Only Super Admins can `bp_moderate` when BuddyPress is network activated' );
 
-        $this->set_current_user( $u2 );
+        self::set_current_user( $u2 );
 
         $this->assertFalse( bp_current_user_can( 'bp_moderate' ), 'Regular Admins cannot `bp_moderate` when BuddyPress is network activated' );
@@ -220 +219 @@
         restore_current_blog();
 
-        $this->set_current_user( $u1 );
+        self::set_current_user( $u1 );
         $this->assertTrue( current_user_can( 'edit_post', $email ), 'Super Admins should be able to edit emails they created' );
 
-        $this->set_current_user( $u2 );
+        self::set_current_user( $u2 );
         $this->assertFalse( current_user_can( 'edit_post', $email ), 'Administrator should not be able to edit emails others created when BuddyPress is network activated' );