Changeset 13980 for trunk/tests/phpunit/testcases/activity/notifications.php

Timestamp:

07/27/2024 04:30:23 PM (2 years ago)

Author:

espellcaste

Message:

Unit Tests: Conducted a thorough review of existing unit tests files and improved them to ensure robustness.

Props imath.

Closes ​https://github.com/buddypress/buddypress/pull/295
Fixes #9081

File:

• trunk/tests/phpunit/testcases/activity/notifications.php (modified) (15 diffs)

trunk/tests/phpunit/testcases/activity/notifications.php

@@ -20 +20 @@
                 $this->u1 = self::factory()->user->create();
                 $this->u2 = self::factory()->user->create();
-                $this->set_current_user( $this->u1 );
+                self::set_current_user( $this->u1 );
 
                 /**
@@ -32 +32 @@
 
         public function tear_down() {
-                $this->set_current_user( $this->current_user );
+                self::set_current_user( $this->current_user );
                 $this->set_permalink_structure( $this->permalink_structure );
-
-                parent::tear_down();
 
                 // Restore the filter
                 add_filter( 'bp_activity_at_name_do_notifications', '__return_false' );
+
+                parent::tear_down();
         }
 
@@ -90 +90 @@
 
                 // Log out
-                $this->set_current_user( 0 );
+                self::set_current_user( 0 );
 
                 // Go to the activity permalink page
@@ -110 +110 @@
                 $this->assertEquals( array( $this->a1 ), wp_list_pluck( $notifications, 'item_id' ) );
 
-                $this->set_current_user( $this->u1 );
+                self::set_current_user( $this->u1 );
         }
 
@@ -129 +129 @@
 
                 // Switch user
-                $this->set_current_user( $this->u2 );
+                self::set_current_user( $this->u2 );
 
                 // Go to the activity permalink page
@@ -149 +149 @@
                 $this->assertEquals( array( $this->a1 ), wp_list_pluck( $notifications, 'item_id' ) );
 
-                $this->set_current_user( $this->u1 );
+                self::set_current_user( $this->u1 );
         }
 
@@ -202 +202 @@
 
                 // Log out
-                $this->set_current_user( 0 );
+                self::set_current_user( 0 );
 
                 // Go to the My Activity page
@@ -223 +223 @@
 
                 // clean up
-                $this->set_current_user( $this->u1 );
+                self::set_current_user( $this->u1 );
         }
 
@@ -242 +242 @@
 
                 // Log out
-                $this->set_current_user( $this->u2 );
+                self::set_current_user( $this->u2 );
 
                 // Go to the My Activity page
@@ -263 +263 @@
 
                 // clean up
-                $this->set_current_user( $this->u1 );
+                self::set_current_user( $this->u1 );
         }
 
@@ -444 +444 @@
 
                 // Attempt to mark 'comment_reply' notifications as read for user 2.
-                $this->set_current_user( $this->u2 );
+                self::set_current_user( $this->u2 );
                 foreach ( $u2_notifications as $i => $n ) {
                         $n = bp_activity_format_notifications( $n->component_action, $n->item_id, $n->secondary_item_id, 1, 'array', $n->id );
@@ -471 +471 @@
                 $u3 = self::factory()->user->create();
 
-                $this->set_current_user( $u1 );
+                self::set_current_user( $u1 );
                 $userdata = get_userdata( $u1 );
 
@@ -487 +487 @@
                 ) );
 
-                $this->set_current_user( $u2 );
+                self::set_current_user( $u2 );
                 $userdata = get_userdata( $u2 );
 
@@ -503 +503 @@
                 self::factory()->comment->update_object( $c1, array( 'comment_approved' => 1 ) );
 
-                $this->set_current_user( $u3 );
+                self::set_current_user( $u3 );
                 $userdata = get_userdata( $u3 );
 
@@ -543 +543 @@
 
                 // Reset.
-                $this->set_current_user( $old_user );
+                self::set_current_user( $old_user );
                 remove_filter( 'bp_disable_blogforum_comments', '__return_false' );
                 remove_filter( 'comment_flood_filter', '__return_false' );
         }
-
 }