Changeset 13971 for trunk/src/bp-friends/bp-friends-cache.php

Timestamp:

07/23/2024 01:32:42 AM (18 months ago)

Author:

espellcaste

Message:

WPCS: miscellaneous fixes for cache-related files in several components.

See #9174 and #9173
Closes ​https://github.com/buddypress/buddypress/pull/331

File:

• trunk/src/bp-friends/bp-friends-cache.php (modified) (5 diffs)

trunk/src/bp-friends/bp-friends-cache.php

@@ -3 +3 @@
  * BuddyPress Friends Caching.
  *
- * Caching functions handle the clearing of cached objects and pages on specific
- * actions throughout BuddyPress.
- *
  * @package BuddyPress
- * @subpackage FriendsCaching
+ * @subpackage FriendsCache
  * @since 1.5.0
  */
@@ -21 +18 @@
  * @param int $friendship_id ID of the friendship whose two members should
  *                           have their friends cache busted.
- * @return bool
  */
 function friends_clear_friend_object_cache( $friendship_id ) {
     $friendship = new BP_Friends_Friendship( $friendship_id );
-    if ( ! $friendship ) {
-        return false;
+
+    if ( empty( $friendship->id ) ) {
+        return;
     }
 
@@ -55 +52 @@
 
     // Clear incremented cache.
-    $friendship = new stdClass;
+    $friendship                    = new stdClass();
     $friendship->initiator_user_id = $initiator_user_id;
     $friendship->friend_user_id    = $friend_user_id;
@@ -135 +132 @@
  * @since 3.0.0
  *
- * @param BP_Friends_Friendship $friendship The friendship object.
+ * @param BP_Friends_Friendship|stdClass $friendship The friendship object.
  */
 function bp_friends_delete_cached_friendships_on_friendship_save( $friendship ) {
@@ -144 +141 @@
 
 // List actions to clear super cached pages on, if super cache is installed.
-add_action( 'friends_friendship_rejected',  'bp_core_clear_cache' );
-add_action( 'friends_friendship_accepted',  'bp_core_clear_cache' );
-add_action( 'friends_friendship_deleted',   'bp_core_clear_cache' );
+add_action( 'friends_friendship_rejected', 'bp_core_clear_cache' );
+add_action( 'friends_friendship_accepted', 'bp_core_clear_cache' );
+add_action( 'friends_friendship_deleted', 'bp_core_clear_cache' );
 add_action( 'friends_friendship_requested', 'bp_core_clear_cache' );