Changeset 13943

Timestamp:

07/03/2024 06:16:22 AM (4 months ago)

Author:

imath

Message:

Only generate rewrite rules when the BP Query Parser is 'rewrites'

Props dontdream

Fixes #9192
Closes ​https://github.com/buddypress/buddypress/pull/325

Location:

trunk/src/bp-core

Files:

• bp-core-update.php (modified) (1 diff)
• classes/class-bp-component.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-update.php

@@ -977 +977 @@
         }
     }
+
+    /*
+     * Force permalinks to be refreshed at next page load.
+     *
+     * This will make sure configs using BP Classic won't include
+     * unnecessary rewrite rules.
+     *
+     * @see https://buddypress.trac.wordpress.org/ticket/9192
+     */
+    if ( 'rewrites' !== bp_core_get_query_parser() ) {
+        bp_delete_rewrite_rules();
+    }
 }
 

trunk/src/bp-core/classes/class-bp-component.php

@@ -1071 +1071 @@
      */
     public function add_rewrite_tags( $rewrite_tags = array() ) {
-        if ( array_filter( $this->rewrite_ids ) ) {
+        if ( 'rewrites' === bp_core_get_query_parser() && array_filter( $this->rewrite_ids ) ) {
             $chunks = bp_rewrites_get_default_url_chunks();
 
@@ -1120 +1120 @@
      */
     public function add_rewrite_rules( $rewrite_rules = array() ) {
-        if ( array_filter( $this->rewrite_ids ) ) {
+        if ( 'rewrites' === bp_core_get_query_parser() && array_filter( $this->rewrite_ids ) ) {
             $priority = 'top';
             $chunks   = array_merge( bp_rewrites_get_default_url_chunks(), $rewrite_rules );
@@ -1212 +1212 @@
         }
 
-        if ( $permastructs ) {
+        if ( 'rewrites' === bp_core_get_query_parser() && $permastructs ) {
             foreach ( $permastructs as $name => $params ) {
                 if ( ! $name || ! isset( $params['permastruct'] ) || ! $params['permastruct'] ) {