Changeset 13941

Timestamp:

06/27/2024 02:59:36 AM (23 months ago)

Author:

imath

Message:

Make sure default en_US BuddyPress strings can be override

Restore bp_core_load_buddypress_textdomain() so that it's possible to customize all BuddyPress default strings with a custom buddypress-en_US.mo translation file.

Fixes #9187
Closes ​https://github.com/buddypress/buddypress/pull/322

Location:

trunk/src/bp-core

Files:

• bp-core-functions.php (modified) (1 diff)
• deprecated/14.0.php (modified) (1 diff)

trunk/src/bp-core/bp-core-functions.php

@@ -2603 +2603 @@
 
 /**
+ * Load the buddypress translation file for current language.
+ *
+ * @since 1.0.2
+ *
+ * @return void
+ */
+function bp_core_load_buddypress_textdomain() {
+    $domain = 'buddypress';
+
+    /*
+     * In most cases, WordPress already loaded BuddyPress textdomain
+     * thanks to the `_load_textdomain_just_in_time()` function.
+     */
+    if ( is_textdomain_loaded( $domain ) ) {
+        return;
+    }
+
+    /*
+     * We only need to keep loading BuddyPress textdomain to allow
+     * the usage of custom `en_US` translation files.
+     */
+    load_plugin_textdomain( $domain );
+}
+add_action( 'bp_core_loaded', 'bp_core_load_buddypress_textdomain' );
+
+/**
  * A JavaScript-free implementation of the search functions in BuddyPress.
  *

trunk/src/bp-core/deprecated/14.0.php

@@ -87 +87 @@
 
 /**
- * Load the buddypress translation file for current language.
- *
- * @since 1.0.2
- * @deprecated 14.0.0
- *
- * @return bool
- */
-function bp_core_load_buddypress_textdomain() {
-    _deprecated_function( __FUNCTION__, '14.0.0' );
-
-    return false;
-}
-
-/**
  * Handle save/update of screen options for the Activity component admin screen.
  *