Changeset 13937 for trunk/src/bp-activity/bp-activity-admin.php

Timestamp:

06/24/2024 05:29:42 PM (10 months ago)

Author:

imath

Message:

Manage BP specific WP List Tables pagination from a central function

• Introduces bp_admin_set_screen_options() to deal with WP List Table pagination

for Activity, Groups, Opt-outs & Site Invitations.

• Deprecates bp_activity_admin_screen_options() & bp_groups_admin_screen_options().

Props emaralive

Fixes #9195
Closes ​https://github.com/buddypress/buddypress/pull/320

File:

• trunk/src/bp-activity/bp-activity-admin.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-admin.php

@@ -15 +15 @@
 
 // Include WP's list table class.
-if ( ! class_exists( 'WP_List_Table' ) ) require( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );
-
-// Per_page screen option. Has to be hooked in extremely early.
-if ( is_admin() && ! empty( $_REQUEST['page'] ) && 'bp-activity' == $_REQUEST['page'] ) {
-    add_filter( 'set-screen-option', 'bp_activity_admin_screen_options', 10, 3 );
+if ( ! class_exists( 'WP_List_Table' ) ) {
+    require ABSPATH . 'wp-admin/includes/class-wp-list-table.php';
 }
 
@@ -139 +136 @@
 }
 add_action( 'wp_ajax_bp-activity-admin-reply', 'bp_activity_admin_reply' );
-
-/**
- * Handle save/update of screen options for the Activity component admin screen.
- *
- * @since 1.6.0
- *
- * @param string $value     Will always be false unless another plugin filters it first.
- * @param string $option    Screen option name.
- * @param string $new_value Screen option form value.
- * @return string|int Option value. False to abandon update.
- */
-function bp_activity_admin_screen_options( $value, $option, $new_value ) {
-    if ( 'toplevel_page_bp_activity_per_page' != $option && 'toplevel_page_bp_activity_network_per_page' != $option )
-        return $value;
-
-    // Per page.
-    $new_value = (int) $new_value;
-    if ( $new_value < 1 || $new_value > 999 )
-        return $value;
-
-    return $new_value;
-}
 
 /**