Changeset 13932

Timestamp:

06/20/2024 07:03:29 PM (6 months ago)

Author:

imath

Message:

Improve how BP extends the WP Theme Support for BP Standalone Themes

To be able to check whether a BP Standalone theme supports future specific BP Component features, we are filtering current_theme_supports-buddypress using the _bp_filter_current_theme_supports() callback function.

When a theme (eg: BP Default theme) was adding a buddypress support with no extra arguments, this callback was wrongly generating PHP errors when the extra arguments were empty.

This commit is making sure these errors are gone!

Props dd32

Fixes #8319
Closes ​https://github.com/buddypress/buddypress/pull/317

File:

• trunk/src/bp-core/bp-core-theme-compatibility.php (modified) (1 diff)

trunk/src/bp-core/bp-core-theme-compatibility.php

@@ -1090 +1090 @@
  */
 function _bp_filter_current_theme_supports( $supports = false, $args = array(), $feature = null ) {
-    $params             = reset( $args );
-    $is_expected_params = array_filter( array_map( 'is_string', array_keys( $params ) ) );
+    $is_expected_params = array();
+
+    if ( isset( $args[0] ) && is_array( $args[0] ) ) {
+        $is_expected_params = array_filter( array_map( 'is_string', array_keys( $args[0] ) ) );
+    }
 
     if ( true === $supports && $is_expected_params ) {